Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document dotnet support #202

Merged
merged 2 commits into from
Oct 18, 2016
Merged

Document dotnet support #202

merged 2 commits into from
Oct 18, 2016

Conversation

stefanbuck
Copy link
Member

No description provided.

Copy link
Member

@josephfrazier josephfrazier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be better if it looked like the other *.json sections of the README. For example:

project.json (.NET Core)

  • dependencies
  • tools

@stefanbuck
Copy link
Member Author

😆 true. I've created the PR on my phone and trust me, editing readmes on such a small screen isn't easy. I know this is a bad excuse for the wrong content. Will fix that tomorrow morning.

@josephfrazier
Copy link
Member

Oh, that's no problem! Let me see if I can push the changes to the branch. 😄

@stefanbuck stefanbuck merged commit f69c359 into master Oct 18, 2016
@stefanbuck stefanbuck deleted the stefanbuck-patch-1 branch October 18, 2016 21:49
@stefanbuck
Copy link
Member Author

Nice collaboration 😊

@josephfrazier
Copy link
Member

Cheers!

P.S. Github recently made this possible across forks as well, as long as the forker agrees: https://github.com/blog/2247-improving-collaboration-with-forks

omadoww added a commit to omadoww/browser-extension that referenced this pull request Nov 20, 2024
* Document dotnet support

* README: format project.json section like other .json sections

See OctoLinker/OctoLinker#202 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants