Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove update notification #1538

Merged
merged 1 commit into from
Apr 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/core/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import insertLink from '@octolinker/helper-insert-link';
import * as storage from '@octolinker/helper-settings';
import helperSortUrls from '@octolinker/helper-sort-urls';
import normaliseResolverResults from '@octolinker/helper-normalise-resolver-results';
import notification from './notification';
import Plugins from './plugin-manager.js';
import debugMode from './debug-mode.js';
import loader from './loader.js';
Expand Down Expand Up @@ -70,7 +69,6 @@ function watch(viewSpy) {

function init() {
debugMode(storage.get('debugMode'));
notification();

injection(() => {
if (!blobReader.hasBlobs()) {
Expand Down
38 changes: 0 additions & 38 deletions packages/core/notification.js

This file was deleted.

1 change: 0 additions & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"repository": "https://github.com/octolinker/octolinker/tree/main/packages/core",
"license": "MIT",
"main": "./index.js",
"releaseDescription": "Fix solidity import paths",
"dependencies": {
"@octolinker/blob-reader": "1.0.0",
"@octolinker/helper-github-api": "1.0.0",
Expand Down
7 changes: 0 additions & 7 deletions packages/helper-settings/SettingsForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -181,13 +181,6 @@ export default class Form extends Component {
checked={state.enablePrivateRepositories}
onClick={linkState(this, 'enablePrivateRepositories')}
/>
<Checkbox
name="showUpdateNotification"
label="Update notification"
description="Show a notification if a new version is available."
checked={state.showUpdateNotification}
onClick={linkState(this, 'showUpdateNotification')}
/>
</form>
<hr />
<Stats counter={stats.counter} />
Expand Down
1 change: 0 additions & 1 deletion packages/helper-settings/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ const store = {};

const defaults = {
enablePrivateRepositories: true,
showUpdateNotification: true,
stats: {
since: Date.now(),
counter: 0,
Expand Down
4 changes: 0 additions & 4 deletions scripts/version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,4 @@ sed -E "s/MARKETING_VERSION = [0-9.]+/MARKETING_VERSION = $npm_package_version/"
dot-json assets/manifest.json version $npm_package_version
dot-json packages/core/package.json version $npm_package_version

echo "Please summarize this release in one sentence"
read note
dot-json packages/core/package.json releaseDescription "$note"

git add assets/manifest.json packages/core/package.json safari/Shared.xcconfig