homebrew: use homebrew-core for fallback link #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so that homebrew formulae in other taps are properly linked to their dependencies in the default tap. For example: https://github.com/Homebrew/homebrew-science/blob/1acf4f470fc8c87f6bcbf19b721ebcd09c7fb025/octave.rb#L44 shows a dependency on autoconf, but the relativeFile resolver points to: https://github.com/Homebrew/homebrew-science/blob/1acf4f470fc8c87f6bcbf19b721ebcd09c7fb025/autoconf.rb which does not exist. Instead, use a new resolver to fall back to: https://github.com/Homebrew/homebrew-core/blob/master/Formula/autoconf.rb
|
LGTM 👍 Just one note. I know our code coverage is quite low, but I would like to improve it. Therefore if you could write a test for |
josephfrazier
added a commit
to josephfrazier/browser-extension
that referenced
this pull request
Aug 4, 2016
Now that OctoLinker#134 is merged, we can just tweak the regex to support linking to formulas in the homebrew-core tap. See here for details on the syntax: https://github.com/caskroom/homebrew-cask/blob/714bd04bebd195500843dbb2cdbef21d65ff8852/doc/cask_language_reference/stanzas/depends_on.md#depends_on-formula Here's a file for testing: https://github.com/caskroom/homebrew-cask/blob/42437e5fcd93b1a3c95376794e6d5eee2b096160/test/support/Casks/with-depends-on-formula-multiple.rb#L8
josephfrazier
added a commit
that referenced
this pull request
Aug 4, 2016
Now that #134 is merged, we can just tweak the regex to support linking to formulas in the homebrew-core tap. See here for details on the syntax: https://github.com/caskroom/homebrew-cask/blob/714bd04bebd195500843dbb2cdbef21d65ff8852/doc/cask_language_reference/stanzas/depends_on.md#depends_on-formula Here's a file for testing: https://github.com/caskroom/homebrew-cask/blob/42437e5fcd93b1a3c95376794e6d5eee2b096160/test/support/Casks/with-depends-on-formula-multiple.rb#L8
omadoww
added a commit
to omadoww/browser-extension
that referenced
this pull request
Nov 20, 2024
Now that OctoLinker/OctoLinker#134 is merged, we can just tweak the regex to support linking to formulas in the homebrew-core tap. See here for details on the syntax: https://github.com/caskroom/homebrew-cask/blob/714bd04bebd195500843dbb2cdbef21d65ff8852/doc/cask_language_reference/stanzas/depends_on.md#depends_on-formula Here's a file for testing: https://github.com/caskroom/homebrew-cask/blob/42437e5fcd93b1a3c95376794e6d5eee2b096160/test/support/Casks/with-depends-on-formula-multiple.rb#L8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that homebrew formulae in other taps are properly
linked to their dependencies in the default tap. For example:
https://github.com/Homebrew/homebrew-science/blob/1acf4f470fc8c87f6bcbf19b721ebcd09c7fb025/octave.rb#L44
shows a dependency on autoconf, but the relativeFile resolver points to:
https://github.com/Homebrew/homebrew-science/blob/1acf4f470fc8c87f6bcbf19b721ebcd09c7fb025/autoconf.rb
which does not exist. Instead, use a new resolver to fall back to:
https://github.com/Homebrew/homebrew-core/blob/master/Formula/autoconf.rb