Update Safari version when using npm version script #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanbuck
force-pushed
the
update-safari-version
branch
from
83b71e9 to
25628d2
Compare
stefanbuck
force-pushed
the
update-safari-version
branch
from
25628d2 to
8b50ca7
Compare
stefanbuck
commented
Jan 19, 2021
| dot-json assets/manifest.json version $npm_package_version | ||
| dot-json packages/core/package.json version $npm_package_version | ||
|
|
||
| echo "Please summarize this release in one sentence" | ||
| read note |
There was a problem hiding this comment.
The read command seem to interfere with tee command. Rearranging the command order is fixing this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Safari version when running
npm versionas outlined in #1167 (comment)