lib: Replaced __cmp__ method with compensating methods for Python3 functionality #4684
Conversation
arohanajit
changed the title
|
@echoix any suggestions here? Upstream has no fix for it. It's not used. |
I'd need to have a deep look for this, as it might be impactful. I think we needed to revert one of my PRs that touched this if I remember well. I'd be cautious and read well. Was it @wenzeslaus that has experience with this file? |
|
Can you update the title too? |
arohanajit
changed the title
|
Great! |
|
This has broken GUI. |
Can you show a situation where it occurs? |
|
GUI ”freezes” with an hourglass the end of startup. |
In the meantime, I figured how to reproduce it. I'm almost finished validating the solution for it, and from what I understand, the implementation of eq isn't really the problem, it is its presence that has a problem. Let me finish debugging, after lunch |
…nctionality (OSGeo#4684) * updated cmp * updated gt * removed cmp
wrt to #1809
This PR updates the
__cmp__method insaferef.pyto be compatible with Python 3. Comparison methods__eq__and
__lt__are implemented to maintain the same functionality without requiring changes elsewhere in the code.Changes:
__eq__method for equality comparison.__lt__method for less-than comparison.__cmp__method now uses the rich comparison methods for its logic.This shouldn't change overall behavior of
saferefclass.