Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prevent network configuration properties from being modified #5971

Draft
wants to merge 1 commit into
base: v-next
Choose a base branch
from
Draft

chore: prevent network configuration properties from being modified #5971

wants to merge 1 commit into from

Conversation

galargh
Copy link
Member

@galargh galargh commented Nov 22, 2024 •
edited
Loading

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

Resolves #5831

This will be taken out of draft after the discussion in https://nomicfoundation.slack.com/archives/C03P6B72ZHU/p1732272638933179 is resolved.

@vercel Vercel
Copy link

vercel bot commented Nov 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 1:35pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 110c251

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 10:38am

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Nov 22, 2024
@galargh galargh changed the title feat: add eslint rule for readonly properties of NetworkConfig chore: prevent network configuration properties from being modified Nov 22, 2024
@galargh galargh mentioned this pull request Nov 22, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on
Projects
Hardhat
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@galargh