Port hardhat-chai-matchers #5946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ChristopherDedominici
added
the
no changeset needed
Contributor
hardhatTotal size of the bundle: List of dependencies (sorted by size) |
Switch the `./src/types.ts` file to a `./src/types.d.ts` file. This allows typescript to correctly pick up the Chai types being extended. There were some small built fixes as well (e.g. changing the type of a passed arg to be `bigint[]`. I added in the type declaration as an import from `./index.ts` and imported the `add-chai-matchers` bootstrap code.
alcuadrado
reviewed
Dec 17, 2024
alcuadrado
reviewed
Dec 17, 2024
v-next/hardhat-chai-matchers/src/internal/hook-handlers/network.ts
Outdated
Show resolved
Hide resolved
…hat-chai-matchers
alcuadrado
reviewed
Dec 17, 2024
v-next/hardhat-chai-matchers/src/internal/hook-handlers/network.ts
Outdated
Show resolved
Hide resolved
alcuadrado
reviewed
Dec 17, 2024
alcuadrado
approved these changes
Dec 17, 2024
Member
alcuadrado
left a comment
alcuadrado
left a comment
There was a problem hiding this comment.
I left some more comments, but feel free to merge after resolving them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOAL:
This PR ports the
hardhat-chai-matchersv2 code to v3.RELATED ISSUES (TODOs):
OVERVIEW:
The v2 code has been ported to v3 by preserving the core logic and structure while introducing minor adjustments.
The adjustments mostly relate to the plugin's initialization process. For a detailed overview, refer to the design doc.
NOTES:
AssertionError. This behavior has been retained rather than switching toHardhatErrorethershave been replaced with those fromhardhat-utils.E.G.: toBeHex -> numberToHexString