Skip to content

fix(android): Android 16 back press navigation failure #11006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 1 commit into from
Dec 10, 2025
Merged

fix(android): Android 16 back press navigation failure #11006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 20 additions & 27 deletions packages/core/ui/frame/index.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { AndroidActivityBackPressedEventData, AndroidActivityNewIntentEventData,
import { Application } from '../../application/application';
import { isEmbedded, setEmbeddedView } from '../embedding';
import { CALLBACKS, FRAMEID, framesCache, setFragmentCallbacks } from './frame-helper-for-android';
import { Device } from '../../platform';
import { SDK_VERSION } from '../../utils';

export * from './frame-common';
export { setFragmentClass } from './fragment';
Expand Down Expand Up @@ -765,34 +765,28 @@ function startActivity(activity: androidx.appcompat.app.AppCompatActivity, frame

let OnBackPressedCallback;

if (parseInt(Device.sdkVersion) >= 33) {
if (SDK_VERSION >= 33) {
OnBackPressedCallback = (<any>androidx.activity.OnBackPressedCallback).extend('com.tns.OnBackPressedCallback', {
handleOnBackPressed() {
if (Trace.isEnabled()) {
Trace.write('NativeScriptActivity.onBackPressed;', Trace.categories.NativeLifecycle);
}

const activity = this['_activity']?.get();

const activity = this['_activity']?.get() as androidx.appcompat.app.AppCompatActivity;
if (!activity) {
if (Trace.isEnabled()) {
Trace.write('NativeScriptActivity.onBackPressed; Activity is null, calling super', Trace.categories.NativeLifecycle);
}

this.setEnabled(false);

return;
}

const args = <AndroidActivityBackPressedEventData>{
eventName: 'activityBackPressed',

object: Application,

android: Application.android,

activity: activity,

cancel: false,
};

Expand All @@ -802,33 +796,32 @@ if (parseInt(Device.sdkVersion) >= 33) {
return;
}

const view = activity._rootView;

let callSuper = false;
const callbacks: AndroidActivityCallbacks = activity[CALLBACKS];
let callSuper: boolean = false;

const viewArgs = <AndroidActivityBackPressedEventData>{
eventName: 'activityBackPressed',
if (callbacks) {
const view = callbacks.getRootView();

object: view,
if (view) {
const viewArgs = <AndroidActivityBackPressedEventData>{
eventName: 'activityBackPressed',
object: view,
activity: activity,
cancel: false,
};

activity: activity,
view.notify(viewArgs);

cancel: false,
};

view?.notify(viewArgs);

// In the case of Frame, use this callback only if it was overridden, since the original will cause navigation issues

if (!viewArgs.cancel && (view?.onBackPressed === Frame.prototype.onBackPressed || !view?.onBackPressed())) {
callSuper = view instanceof Frame ? !Frame.goBack() : true;
// In the case of Frame, use this callback only if it was overridden, since the original will cause navigation issues
if (!viewArgs.cancel && (view.onBackPressed === Frame.prototype.onBackPressed || !view.onBackPressed())) {
callSuper = view instanceof Frame ? !Frame.goBack() : true;
}
}
}

if (callSuper) {
this.setEnabled(false);

activity.getOnBackPressedDispatcher().onBackPressed();

this.setEnabled(true);
}
},
Expand Down