Skip to content

fix(webpack): hmr handling #11002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 1 commit into from
Dec 4, 2025
Merged

fix(webpack): hmr handling #11002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/webpack5/src/configuration/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,11 @@ export default function (config: Config, env: IWebpackEnv = _env): Config {
env.commonjs = true;
}

if (env.hmr) {
// HMR webpack should use CommonJS
env.commonjs = true;
}

// config.stats({
// logging: 'verbose'
// })
Expand Down
13 changes: 11 additions & 2 deletions packages/webpack5/src/loaders/nativescript-hot-loader/hmr.runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,19 @@ if (module.hot) {
};

const hasUpdate = () => {
return [
// Prefer platform-agnostic JS hot-update manifests; fall back to JSON
// if needed. On iOS, the .hot-update.js files are present under the
// app folder (see platforms/ios <app>/bundle.*.hot-update.js), while on
// Android the JSON manifests are used by HMR. Checking JS first keeps
// behavior correct for iOS without regressing Android.
const candidates = [
`~/bundle.${__webpack_hash__}.hot-update.js`,
`~/runtime.${__webpack_hash__}.hot-update.js`,
`~/bundle.${__webpack_hash__}.hot-update.json`,
`~/runtime.${__webpack_hash__}.hot-update.json`,
].some((path) => requireExists(path));
];

return candidates.some((path) => requireExists(path));
};

if (global.__onLiveSync !== global[hmrRuntimeLastLiveSyncSymbol]) {
Expand Down
Loading