feat(search-bar): add clear button color support #10903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixed issue #5193 — added support for clear button color in SearchBar (Android). |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for customizing the clear button color in the SearchBar component across iOS and Android platforms. The change introduces a new clearButtonColor property that allows developers to style the clear/close button.
- Added
clearButtonColorPropertyto the SearchBar common properties - Implemented platform-specific handlers for iOS using
tintColoron the clear button - Implemented platform-specific handlers for Android using
setColorFilteron the close button
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/core/ui/search-bar/search-bar-common.ts | Defines the new clearButtonColorProperty with Color type and equality comparer |
| packages/core/ui/search-bar/index.ios.ts | Implements iOS-specific handler using valueForKey('clearButton') and tintColor |
| packages/core/ui/search-bar/index.android.ts | Implements Android-specific handler using resource ID lookup and setColorFilter |
Comments suppressed due to low confidence (1)
packages/core/ui/search-bar/search-bar-common.ts:14
- The
clearButtonColorproperty declaration is missing from theSearchBarBaseclass. Addpublic clearButtonColor: Color;after line 14 to maintain consistency with other properties liketextFieldBackgroundColorandtextFieldHintColor.
export abstract class SearchBarBase extends View implements SearchBarDefinition {
public static submitEvent = 'submit';
public static clearEvent = 'clear';
public text: string;
public hint: string;
public textFieldBackgroundColor: Color;
public textFieldHintColor: Color;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
NathanWalker
approved these changes
Oct 30, 2025
|
View your CI Pipeline Execution ↗ for commit 8bb0dc2
☁️ Nx Cloud last updated this comment at |
CatchABus
requested changes
Oct 30, 2025
NathanWalker
changed the title
NathanWalker
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Currently, the SearchBar component on Android does not allow developers to customize the clear button color.
This results in inconsistency with iOS, where developers can already modify the color to match app themes.
What is the new behavior?
This PR introduces support for customizing the clear button color in the SearchBar component on Android.
Developers can now apply any desired color for consistent design and theming across platforms.
Fixes #5193
Example Usage: