Skip to content

fix(android/text-base): remove extra font padding for custom fonts gl… #10771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 2 commits into from
Nov 4, 2025
Merged

fix(android/text-base): remove extra font padding for custom fonts gl… #10771

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e44b516
fix(android/text-base): remove extra font padding for custom fonts gl…
ahmedsalman72 Jul 26, 2025
7167389
Delete docs/android-font-padding-fix.md
NathanWalker Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/core/ui/text-base/index.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,11 @@ export class TextBase extends TextBaseCommon {
super.initNativeView();
initializeTextTransformation();
const nativeView = this.nativeTextViewProtected;

// Fix for custom font over-height issue on Android
// Disable font padding to prevent extra spacing around text
nativeView.setIncludeFontPadding(false);
Copy link
Contributor

@NathanWalker NathanWalker Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious @CatchABus do you see any issue with this fix?


this._defaultTransformationMethod = nativeView.getTransformationMethod();
this._defaultMovementMethod = nativeView.getMovementMethod();
this._minHeight = nativeView.getMinHeight();
Expand Down