Metadata accessor #5650
Merged
Metadata accessor #5650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Michał Zientkiewicz <[email protected]>
mzient
force-pushed
the
metadata_accessor
branch
from
6618dd0
to
9431cdc
Compare
Signed-off-by: Michal Zientkiewicz <[email protected]>
|
CI MESSAGE: [18914711]: BUILD STARTED |
|
CI MESSAGE: [18914711]: BUILD PASSED |
banasraf
approved these changes
Oct 1, 2024
mdabek-nvidia
approved these changes
Oct 1, 2024
|
|
||
| template <typename Backend> | ||
| auto GetProperty<Backend>::GetPropertyReader(std::string_view key) -> PropertyReader { | ||
| if (key == "source_info") { |
There was a problem hiding this comment.
This if-else is fine for a couple (2-3) of properties. If we expect to have more of these I would recommend using different approach - e.g. unordered_map.
There was a problem hiding this comment.
Realistically, I'd expect maybe 5 qualitatively different properties. If we have anything more, it'll likely be standardized somehow and likely not even hardcoded.
Having said that - this function is called only on operator's construction - so it's not on a critical path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Refactoring (Redesign of existing code that doesn't affect functionality)
Description:
This PR reimplements GetProperty to allow for:
It also introduces
DataNode.metadatafunction and a shortcut forsource_info.NOTE
layoutdoesn't get a dedicated accessor, since we want to have a static (build-time) layout and dtype.Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A