Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

回復「修課人數」並且新增「學生清單」標題 #233

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

ntut-xuan
Copy link
Collaborator

@ntut-xuan ntut-xuan commented Mar 4, 2024

Description

在這個 PR 中,我回復了修課人數並且新增學生清單標題。

image

用於顯示目前的修課人數,並且回復學生清單的標題,並在兩個不同的列表中插一個空白來進行區隔。

How to review it

  • 確認畫面正常顯示無誤。

@rileychh rileychh force-pushed the feature/student_count_with_ui_optimize branch from 04972d0 to de73778 Compare January 31, 2025 07:30
Copy link
Member

@rileychh rileychh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builds and works well on my Pixel 7.
Works on my machine

@rileychh rileychh dismissed James-Lu-none’s stale review January 31, 2025 07:56

Requested changes are applied.

@rileychh rileychh merged commit 31930fd into master Jan 31, 2025
4 checks passed
@rileychh rileychh deleted the feature/student_count_with_ui_optimize branch January 31, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants