feat: support "only when external display show menu bar icon" option (#1817)

Yifei0727 · neo · web-flow · commit d4309e6ec59a · 2025-11-16T10:58:59.000+01:00
Co-authored-by: neo &lt;yifei0727@no-reply.users.github.io&gt;
diff --git a/MonitorControl/Enums/PrefKey.swift b/MonitorControl/Enums/PrefKey.swift
@@ -191,6 +191,7 @@ enum MenuIcon: Int {
   case show = 0
   case sliderOnly = 1
   case hide = 2
+  case externalOnly = 3
 }
 
 enum MenuItemStyle: Int {
diff --git a/MonitorControl/Support/MenuHandler.swift b/MonitorControl/Support/MenuHandler.swift
@@ -33,7 +33,19 @@ class MenuHandler: NSMenu, NSMenuDelegate {
     if !dontClose {
       self.cancelTrackingWithoutAnimation()
     }
-    app.updateStatusItemVisibility(prefs.integer(forKey: PrefKey.menuIcon.rawValue) == MenuIcon.show.rawValue ? true : false)
+    let menuIconPref = prefs.integer(forKey: PrefKey.menuIcon.rawValue)
+    var showIcon = false
+    if menuIconPref == MenuIcon.show.rawValue {
+      showIcon = true
+    } else if menuIconPref == MenuIcon.externalOnly.rawValue {
+      let externalDisplays = DisplayManager.shared.displays.filter {
+        CGDisplayIsBuiltin($0.identifier) == 0
+      }
+      if externalDisplays.count > 0 {
+        showIcon = true
+      }
+    }
+    app.updateStatusItemVisibility(showIcon)
     self.clearMenu()
     let currentDisplay = DisplayManager.shared.getCurrentDisplay()
     var displays: [Display] = []
diff --git a/MonitorControl/UI/Base.lproj/Main.storyboard b/MonitorControl/UI/Base.lproj/Main.storyboard
@@ -368,6 +368,7 @@
                                                     <items>
                                                         <menuItem title="Always show in the menu bar" state="on" id="MM0-Lf-VgF"/>
                                                         <menuItem title="Only if at least one slider is present" tag="1" id="xLa-PN-rsq"/>
++                                                       <menuItem title="Only when external display is present" tag="3" id="Tb1-6s-qOo"/>
                                                         <menuItem title="Always hide" tag="2" id="6mo-7S-oOO"/>
                                                     </items>
                                                 </menu>
diff --git a/MonitorControl/UI/cs.lproj/Main.strings b/MonitorControl/UI/cs.lproj/Main.strings
@@ -376,6 +376,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "Jen pokud je k dispozici alespo&#328; jeden posuvn&iacute;k";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "Pouze kdy&#382; je extern&iacute; displej p&#345;&iacute;tomen";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "Standardn&iacute; i vlastn&iacute; zkratky";
 
diff --git a/MonitorControl/UI/de.lproj/Main.strings b/MonitorControl/UI/de.lproj/Main.strings
@@ -376,6 +376,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "Nur wenn mindestens ein Regler vorhanden ist";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "Nur wenn externer Bildschirm vorhanden ist";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "Sowohl Standard- als auch benutzerdefinierte Tastenkombinationen";
 
diff --git a/MonitorControl/UI/en.lproj/Main.strings b/MonitorControl/UI/en.lproj/Main.strings
@@ -376,6 +376,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "Only if at least one slider is present";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "Only when external display is present";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "Both standard and custom shortcuts";
 
diff --git a/MonitorControl/UI/es.lproj/Main.strings b/MonitorControl/UI/es.lproj/Main.strings
@@ -376,6 +376,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "S&oacute;lo si hay presente al menos un slider";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "Solo cuando la pantalla externa est&aacute; presente";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "Ambos, atajos est&aacute;ndar y personalizados";
 
diff --git a/MonitorControl/UI/fr.lproj/Main.strings b/MonitorControl/UI/fr.lproj/Main.strings
@@ -376,6 +376,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "Uniquement si au moins un curseur est pr&eacute;sent";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "Seulement lorsqu'un &eacute;cran externe est pr&eacute;sent";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "Raccourcis standard et personnalis&eacute;s";
 
diff --git a/MonitorControl/UI/hi.lproj/Main.strings b/MonitorControl/UI/hi.lproj/Main.strings
@@ -428,6 +428,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "&#2325;&#2375;&#2357;&#2354; &#2340;&#2349;&#2368; &#2332;&#2348; &#2325;&#2350; &#2360;&#2375; &#2325;&#2350; &#2319;&#2325; &#2360;&#2381;&#2354;&#2366;&#2311;&#2337;&#2352; &#2350;&#2380;&#2332;&#2370;&#2342; &#2361;&#2379;";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "&#2325;&#2375;&#2357;&#2354; &#2340;&#2349;&#2368; &#2332;&#2348; &#2348;&#2366;&#2361;&#2352;&#2368; &#2337;&#2367;&#2360;&#2381;&#2346;&#2381;&#2354;&#2375; &#2350;&#2380;&#2332;&#2370;&#2342; &#2361;&#2379;";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "&#2350;&#2366;&#2344;&#2325; &#2324;&#2352; &#2325;&#2360;&#2381;&#2335;&#2350; &#2342;&#2379;&#2344;&#2379;&#2306; &#2358;&#2377;&#2352;&#2381;&#2335;&#2325;&#2335;";
 
diff --git a/MonitorControl/UI/hu.lproj/Main.strings b/MonitorControl/UI/hu.lproj/Main.strings
@@ -376,6 +376,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "Csak ha legal&aacute;bb egy vez&eacute;rl&#337; megjelenik";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "Csak ha k&uuml;ls&#337; kijelz&#337; van jelen";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "Hagyom&aacute;nyos &eacute;s egyedi billenty&#369;kombin&aacute;ci&oacute;k";
 
diff --git a/MonitorControl/UI/it.lproj/Main.strings b/MonitorControl/UI/it.lproj/Main.strings
@@ -376,6 +376,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "Solo se &egrave; presente almeno uno slider";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "Solo quando &egrave; presente un display esterno";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "Entrambe le abbreviazioni standard e personalizzate";
 
diff --git a/MonitorControl/UI/ja.lproj/Main.strings b/MonitorControl/UI/ja.lproj/Main.strings
@@ -428,6 +428,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "&#23569;&#12394;&#12367;&#12392;&#12418; 1 &#12388;&#12398;&#12473;&#12521;&#12452;&#12480;&#12540;&#12364;&#23384;&#22312;&#12377;&#12427;&#22580;&#21512;&#12398;&#12415;";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "&#22806;&#37096;&#12487;&#12451;&#12473;&#12503;&#12524;&#12452;&#12364;&#12354;&#12427;&#22580;&#21512;&#12398;&#12415;";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "&#27161;&#28310;&#12471;&#12519;&#12540;&#12488;&#12459;&#12483;&#12488;&#12392;&#12459;&#12473;&#12479;&#12512;&#12471;&#12519;&#12540;&#12488;&#12459;&#12483;&#12488;&#12398;&#20001;&#26041;";
 
diff --git a/MonitorControl/UI/ko.lproj/Main.strings b/MonitorControl/UI/ko.lproj/Main.strings
@@ -376,6 +376,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "&#49836;&#46972;&#51060;&#45908;&#44032; &#54616;&#45208; &#51060;&#49345; &#51080;&#45716; &#44221;&#50864;&#50640;&#47564;";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "&#50808;&#48512; &#46356;&#49828;&#54540;&#47112;&#51060;&#44032; &#51080;&#51012; &#46412;&#47564;";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "&#54364;&#51456; &#48143; &#49324;&#50857;&#51088; &#51221;&#51032; &#45800;&#52629;&#53412; &#46168; &#45796;";
 
diff --git a/MonitorControl/UI/nl.lproj/Main.strings b/MonitorControl/UI/nl.lproj/Main.strings
@@ -376,6 +376,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "Alleen als er ten minste &eacute;&eacute;n schuifregelaar aanwezig is";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "Alleen wanneer een extern beeldscherm aanwezig is";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "Zowel standaard als aangepaste sneltoetsen";
 
diff --git a/MonitorControl/UI/pl.lproj/Main.strings b/MonitorControl/UI/pl.lproj/Main.strings
@@ -376,6 +376,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "Tylko w przypadku obecno&#347;ci co najmniej jednego suwaka";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "Tylko gdy monitor zewn&#281;trzny jest obecny";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "Skr&oacute;ty standardowe oraz u&#380;ytkownika";
 
diff --git a/MonitorControl/UI/pt-BR.lproj/Main.strings b/MonitorControl/UI/pt-BR.lproj/Main.strings
@@ -379,6 +379,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "Apenas se pelo menos um controle deslizante estiver presente";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "Somente quando o monitor externo estiver presente";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "Atalhos padr&atilde;o e personalizados";
 
diff --git a/MonitorControl/UI/pt-PT.lproj/Main.strings b/MonitorControl/UI/pt-PT.lproj/Main.strings
@@ -379,6 +379,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "Apenas se pelo menos um controle deslizante estiver presente";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "Apenas quando um ecr&atilde; externo estiver presente";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "Atalhos padr&atilde;o e personalizados";
 
diff --git a/MonitorControl/UI/ru.lproj/Main.strings b/MonitorControl/UI/ru.lproj/Main.strings
@@ -376,6 +376,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "&#1058;&#1086;&#1083;&#1100;&#1082;&#1086; &#1087;&#1088;&#1080; &#1085;&#1072;&#1083;&#1080;&#1095;&#1080;&#1080; &#1093;&#1086;&#1090;&#1103; &#1073;&#1099; &#1086;&#1076;&#1085;&#1086;&#1075;&#1086; &#1087;&#1086;&#1083;&#1079;&#1091;&#1085;&#1082;&#1072;";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "&#1058;&#1086;&#1083;&#1100;&#1082;&#1086; &#1087;&#1088;&#1080; &#1085;&#1072;&#1083;&#1080;&#1095;&#1080;&#1080; &#1074;&#1085;&#1077;&#1096;&#1085;&#1077;&#1075;&#1086; &#1076;&#1080;&#1089;&#1087;&#1083;&#1077;&#1103;";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "&#1050;&#1072;&#1082; &#1089;&#1090;&#1072;&#1085;&#1076;&#1072;&#1088;&#1090;&#1085;&#1099;&#1077;, &#1090;&#1072;&#1082; &#1080; &#1087;&#1086;&#1083;&#1100;&#1079;&#1086;&#1074;&#1072;&#1090;&#1077;&#1083;&#1100;&#1089;&#1082;&#1080;&#1077; &#1089;&#1086;&#1095;&#1077;&#1090;&#1072;&#1085;&#1080;&#1103; &#1082;&#1083;&#1072;&#1074;&#1080;&#1096;";
 
diff --git a/MonitorControl/UI/sk.lproj/Main.strings b/MonitorControl/UI/sk.lproj/Main.strings
@@ -401,6 +401,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "Iba ak je pr&iacute;tomn&yacute; aspo&#328; jeden posuvn&iacute;k";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "Iba ke&#271; je pr&iacute;tomn&yacute; extern&yacute; displej";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "&Scaron;tandardn&eacute; aj vlastn&eacute; skratky";
 
diff --git a/MonitorControl/UI/tr.lproj/Main.strings b/MonitorControl/UI/tr.lproj/Main.strings
@@ -376,6 +376,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "Yaln&#305;zca en az bir kayd&#305;r&#305;c&#305; varsa";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "Yaln&#305;zca harici ekran mevcut oldu&#287;unda";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "Hem standart hem de &ouml;zel k&#305;sayollar";
 
diff --git a/MonitorControl/UI/zh-Hans.lproj/Main.strings b/MonitorControl/UI/zh-Hans.lproj/Main.strings
@@ -376,6 +376,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "&#21482;&#26377;&#24403;&#33267;&#23569;&#19968;&#20010;&#28369;&#26438;&#21487;&#29992;&#26102;";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "&#20165;&#24403;&#23384;&#22312;&#22806;&#32622;&#26174;&#31034;&#22120;&#26102;";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "&#26631;&#20934;&#21450;&#33258;&#23450;&#20041;&#24555;&#25463;&#38190;";
 
diff --git a/MonitorControl/UI/zh-Hant-TW.lproj/Main.strings b/MonitorControl/UI/zh-Hant-TW.lproj/Main.strings
@@ -376,6 +376,9 @@
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "&#21482;&#26377;&#30070;&#33267;&#23569;&#19968;&#20491;&#28369;&#26751;&#21487;&#29992;&#26178;";
 
+/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
+"Tb1-6s-qOo.title" = "&#20677;&#30070;&#23384;&#22312;&#22806;&#32622;&#39023;&#31034;&#22120;&#26178;";
+
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "&#27161;&#28310;&#21450;&#33258;&#23450;&#24555;&#36895;&#37749;";
 

Original file line number	Diff line number	Diff line change
`@@ -191,6 +191,7 @@ enum MenuIcon: Int {`
`191`	`191`	`case show = 0`
`192`	`192`	`case sliderOnly = 1`
`193`	`193`	`case hide = 2`
	`194`	`+ case externalOnly = 3`
`194`	`195`	`}`
`195`	`196`
`196`	`197`	`enum MenuItemStyle: Int {`
-Original file line number
+Diff line change
 /* Class = "NSMenuItem"; title = "Only if at least one slider is present"; ObjectID = "xLa-PN-rsq"; */
 "xLa-PN-rsq.title" = "Jen pokud je k dispozici alespoň jeden posuvník";
 +/* Class = "NSMenuItem"; title = "Only when external display is present"; ObjectID = "Tb1-6s-qOo"; */
 +"Tb1-6s-qOo.title" = "Pouze když je externí displej přítomen";
++
 /* Class = "NSMenuItem"; title = "Both standard and custom shortcuts"; ObjectID = "xQJ-aJ-VhH"; */
 "xQJ-aJ-VhH.title" = "Standardní i vlastní zkratky";