-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added steps for SKU #124951
added steps for SKU #124951
Conversation
@ehvs : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 606d823:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/openshift/howto-gpu-workloads.md | Details |
articles/openshift/howto-gpu-workloads.md
- Line 193, Column 195: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/windows-server/virtualization/hyper-v/plan/should-i-create-a-generation-1-or-2-virtual-machine-in-hyper-v' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 197, Column 80: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/ncast4v3-series?tabs=sizebasic#feature-support' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 199, Column 66: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/nca100v4-series?tabs=sizebasic' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 193, Column 195: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/windows-server/virtualization/hyper-v/plan/should-i-create-a-generation-1-or-2-virtual-machine-in-hyper-v' will be broken in isolated environments. Replace with a relative link.
- Line 197, Column 80: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/ncast4v3-series?tabs=sizebasic#feature-support' will be broken in isolated environments. Replace with a relative link.
- Line 199, Column 66: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/nca100v4-series?tabs=sizebasic' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
|
||
If using `Standard_NC4as_T4_v3` it is supported both versions, as mentioned at [Feature support](https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/ncast4v3-series?tabs=sizebasic#feature-support). So no changes is required. | ||
|
||
If using `Standard_NC24ads_A100_v4`, only **Generation 2 VM** is [supported](https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/nca100v4-series?tabs=sizebasic). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure if it is ok to add links, but if yes, I need to fix this line, since the url should point to =sizebasic#feature-support
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just my 2 Cents
Learn Build status updates of commit 5aeba4d:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/openshift/howto-gpu-workloads.md | Details |
articles/openshift/howto-gpu-workloads.md
- Line 193, Column 217: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/windows-server/virtualization/hyper-v/plan/should-i-create-a-generation-1-or-2-virtual-machine-in-hyper-v' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 197, Column 80: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/ncast4v3-series?tabs=sizebasic#feature-support' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 199, Column 66: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/nca100v4-series?tabs=sizebasic#feature-support' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 193, Column 217: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/windows-server/virtualization/hyper-v/plan/should-i-create-a-generation-1-or-2-virtual-machine-in-hyper-v' will be broken in isolated environments. Replace with a relative link.
- Line 197, Column 80: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/ncast4v3-series?tabs=sizebasic#feature-support' will be broken in isolated environments. Replace with a relative link.
- Line 199, Column 66: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/nca100v4-series?tabs=sizebasic#feature-support' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
@@ -188,6 +188,36 @@ ARO uses Kubernetes MachineSet to create machine sets. The procedure below expla | |||
|
|||
1. Verify the other data in the yaml file. | |||
|
|||
#### Ensure the correct SKU is set | |||
|
|||
Depending on the image used for the machine set, both values for `image.sku` and `image.version` must be set accordingly. This is to ensure if generation 1 or 2 virtual machine for Hyper-V will be used. More details [here](https://learn.microsoft.com/en-us/windows-server/virtualization/hyper-v/plan/should-i-create-a-generation-1-or-2-virtual-machine-in-hyper-v). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the format of the link to say "See xxx for more information."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not completely sure if my new commit is the way that you intended. Please let me know if need further adjustments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comments. Also, please change the metadata at the top to reflect the current date. Thanks.
Learn Build status updates of commit e2dcc09:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/openshift/howto-gpu-workloads.md | Details |
articles/openshift/howto-gpu-workloads.md
- Line 9, Column 10: [Warning: ms-date-invalid - See documentation]
Invalid date format for 'ms.date': '29/11/2024'. If specified, must be a date in format M/D/YYYY, no more than 30 days from today. If you don't specify ms.date, the date will be updated automatically.
- Line 193, Column 208: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/windows-server/virtualization/hyper-v/plan/should-i-create-a-generation-1-or-2-virtual-machine-in-hyper-v' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 197, Column 79: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/ncast4v3-series?tabs=sizebasic#feature-support' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 199, Column 66: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/nca100v4-series?tabs=sizebasic#feature-support' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 193, Column 208: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/windows-server/virtualization/hyper-v/plan/should-i-create-a-generation-1-or-2-virtual-machine-in-hyper-v' will be broken in isolated environments. Replace with a relative link.
- Line 197, Column 79: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/ncast4v3-series?tabs=sizebasic#feature-support' will be broken in isolated environments. Replace with a relative link.
- Line 199, Column 66: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/nca100v4-series?tabs=sizebasic#feature-support' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Learn Build status updates of commit cfd6872:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/openshift/howto-gpu-workloads.md | Details |
articles/openshift/howto-gpu-workloads.md
- Line 193, Column 208: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/windows-server/virtualization/hyper-v/plan/should-i-create-a-generation-1-or-2-virtual-machine-in-hyper-v' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 197, Column 79: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/ncast4v3-series?tabs=sizebasic#feature-support' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 199, Column 66: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/nca100v4-series?tabs=sizebasic#feature-support' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 193, Column 208: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/windows-server/virtualization/hyper-v/plan/should-i-create-a-generation-1-or-2-virtual-machine-in-hyper-v' will be broken in isolated environments. Replace with a relative link.
- Line 197, Column 79: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/ncast4v3-series?tabs=sizebasic#feature-support' will be broken in isolated environments. Replace with a relative link.
- Line 199, Column 66: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/gpu-accelerated/nca100v4-series?tabs=sizebasic#feature-support' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Hi @johnmarco lmk if there is any other changes needed. |
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
#sign-off |
Thank you for making the changes. |
Learn Build status updates of commit 678def2: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
The article, articles/openshift/howto-gpu-workloads.md, might benefit from an edit pass. An editor will notify the listed author and recent contributors. |
This is based on known issues, and the resolution provided at: https://access.redhat.com/solutions/7074330