Skip to content

Conversation

@earloc
Copy link
Contributor

@earloc earloc commented Nov 25, 2024

fixes #124930

@prmerger-automator
Copy link
Contributor

@earloc : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 93fc56d:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/azure-functions/functions-bindings-warmup.md ⚠️Warning Details

articles/azure-functions/functions-bindings-warmup.md

  • Line 95, Column 1: [Warning: invalid-code] The code snippet "~/azure-functions-nodejs-v4/js/src/functions/warmupTrigger.js" could not be found.
  • Line 133, Column 1: [Warning: invalid-code] The code snippet "~/azure-functions-nodejs-v4/ts/src/functions/warmupTrigger.ts" could not be found.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor Author

@earloc earloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are those samples located?

~/azure-functions-nodejs-v4/ts/src/functions/warmupTrigger.ts

@earloc
Copy link
Contributor Author

earloc commented Nov 25, 2024

where are those samples located?

~/azure-functions-nodejs-v4/ts/src/functions/warmupTrigger.ts

found it:
Azure/azure-functions-nodejs-samples#33

@Jak-MS
Copy link
Contributor

Jak-MS commented Nov 25, 2024

@ggailey777
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Nov 25, 2024
@ggailey777
Copy link
Contributor

I need to make some revisions to this PR, which are now included, along with this commit, in this new PR: https://github.com/MicrosoftDocs/azure-docs-pr/pull/291658
Thanks @earloc for your help. Since we have your commit now in the private repo, we can #please-close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading sample: Azure Functions warmup-trigger for JavaScript V4 not working

3 participants