Skip to content

feat: Turn on PortfolioView #28661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darkwing merged 5 commits into from
Nov 27, 2024
Merged

feat: Turn on PortfolioView #28661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45c884d
feat: Set PORTFOLIO_VIEW feature flag to true
gambinish Nov 22, 2024
ef47c5b
chore: Update privacy-snapshot with linea host
gambinish Nov 22, 2024
93fb977
fix: Update e2e background state after feature flag gets turned on
gambinish Nov 22, 2024
a01df8c
chore: Rebase develop, address conflicts
gambinish Nov 26, 2024
b40ca8e
Merge branch 'develop' into feat/portfolio-view-feature-flag-removal
salimtb Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ env:
# Determines if feature flagged Chain permissions
- CHAIN_PERMISSIONS: ''
# Determines if Portfolio View UI should be shown
- PORTFOLIO_VIEW: ''
- PORTFOLIO_VIEW: 'true'
# Enables use of test gas fee flow to debug gas fee estimation
- TEST_GAS_FEE_FLOWS: false
# Temporary mechanism to enable security alerts API prior to release
Expand Down
10 changes: 8 additions & 2 deletions test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-background-state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,11 @@
"redesignedTransactionsEnabled": "boolean",
"tokenSortConfig": "object",
"tokenNetworkFilter": {
"0x539": "boolean"
"0x1": "boolean",
"0x539": "boolean",
"0xaa36a7": "boolean",
"0xe705": "boolean",
"0xe708": "boolean"
},
"shouldShowAggregatedBalancePopover": "boolean"
},
Expand Down Expand Up @@ -324,7 +328,9 @@
"TokenListController": {
"tokenList": "object",
"tokensChainsCache": {
"0x539": "object"
"0x1": "object",
"0x539": "object",
"0xe708": "object"
},
"preventPollingOnNetworkRestart": false
},
Expand Down
16 changes: 13 additions & 3 deletions test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-ui-state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,14 @@
"showMultiRpcModal": "boolean",
"isRedesignedConfirmationsDeveloperEnabled": "boolean",
"tokenSortConfig": "object",
"tokenNetworkFilter": {
"0x1": "boolean",
"0x539": "boolean",
"0xaa36a7": "boolean",
"0xe705": "boolean",
"0xe708": "boolean"
},
"shouldShowAggregatedBalancePopover": "boolean",
"tokenNetworkFilter": { "0x539": "boolean" },
"redesignedConfirmationsEnabled": true,
"redesignedTransactionsEnabled": "boolean"
},
Expand Down Expand Up @@ -174,15 +180,19 @@
"gasEstimateType": "none",
"nonRPCGasFeeApisDisabled": "boolean",
"tokenList": "object",
"tokensChainsCache": { "0x539": "object" },
"tokensChainsCache": {
"0x1": "object",
"0x539": "object",
"0xe708": "object"
},
"tokenBalances": "object",
"preventPollingOnNetworkRestart": false,
"tokens": "object",
"ignoredTokens": "object",
"detectedTokens": "object",
"allTokens": {},
"allIgnoredTokens": {},
"allDetectedTokens": {},
"tokenBalances": "object",
"smartTransactionsState": {
"fees": {},
"feesByChainId": "object",
Expand Down
7 changes: 7 additions & 0 deletions test/e2e/tests/tokens/import-tokens.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,13 @@ describe('Import flow', function () {
'[data-testid="token-list-loading-message"]',
);

await driver.assertElementNotPresent(
'[data-testid="token-list-loading-message"]',
);

await driver.clickElement('[data-testid="sort-by-networks"]');
await driver.clickElement('[data-testid="network-filter-current"]');

const expectedTokenListElementsAreFound =
await driver.elementCountBecomesN('.multichain-token-list-item', 4);
assert.equal(expectedTokenListElementsAreFound, true);
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/tests/tokens/token-details.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ describe('Token Details', function () {

const openTokenDetails = async (driver: Driver) => {
await driver.clickElement('[data-testid="account-overview__asset-tab"]');
const [, tkn] = await driver.findElements(
const [, , tkn] = await driver.findElements(
'[data-testid="multichain-token-list-button"]',
);
await tkn.click();
Expand Down
Loading