test: [POM] Migrate add token e2e tests to TS and Page Object Model #28658

chloeYue · 2024-11-22T17:37:24Z

Description

Fix flaky test add hide token, the reason of flakiness is a race condition that we assert number of listed tokens before all tokens are displayed
Migrate add token e2e tests to TS and Page Object Model

Related issues

Fixes: #28681 #28664

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-22T17:38:24Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-11-22T18:08:43Z

Builds ready [73eb1fc]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2167 ± 148 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	408	2519	2049	454	218
		domContentLoaded	1671	2922	2128	302	145
		load	1675	2930	2167	309	148
		domInteractive	28	97	46	21	10
		backgroundConnect	9	98	52	26	12
		firstReactRender	91	297	139	56	27
		getState	5	88	21	22	10
		initialActions	0	1	0	0	0
		loadScripts	1169	2281	1564	265	127
		setupStore	6	73	13	14	7
		uiStartup	1926	3203	2436	324	156

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-25T21:21:40Z

Builds ready [6d122bc]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1880 ± 71 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1611	2123	1880	140	67
		domContentLoaded	1591	2038	1838	128	61
		load	1613	2210	1880	149	71
		domInteractive	24	98	43	21	10
		backgroundConnect	10	177	43	38	18
		firstReactRender	18	95	46	26	13
		getState	6	92	24	24	11
		initialActions	0	1	0	0	0
		loadScripts	1085	1550	1349	119	57
		setupStore	6	86	17	20	10
		uiStartup	1788	2722	2119	223	107

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-26T08:57:28Z

Builds ready [07de661]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1623 ± 75 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1469	2222	1629	156	75
		domContentLoaded	1459	2127	1597	141	68
		load	1469	2222	1623	156	75
		domInteractive	19	70	32	15	7
		backgroundConnect	8	93	28	22	10
		firstReactRender	15	78	32	21	10
		getState	4	52	15	17	8
		initialActions	0	1	0	0	0
		loadScripts	1076	1612	1179	115	55
		setupStore	6	65	16	18	8
		uiStartup	1618	2677	1835	242	116

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

seaona

Nice investigation and fix with POM 🔥

metamaskbot · 2024-11-27T09:03:36Z

Builds ready [577f106]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1747 ± 88 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	237	2238	1616	485	233
		domContentLoaded	1457	2219	1716	188	90
		load	1512	2241	1747	184	88
		domInteractive	21	206	48	43	21
		backgroundConnect	8	66	34	17	8
		firstReactRender	16	104	33	24	12
		getState	6	71	21	20	10
		initialActions	0	0	0	0	0
		loadScripts	1079	1797	1278	150	72
		setupStore	6	56	18	17	8
		uiStartup	1670	2496	1966	208	100

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

migrate test

73eb1fc

chloeYue added the team-extension-platform Extension Platform team label Nov 22, 2024

chloeYue self-assigned this Nov 22, 2024

chloeYue requested a review from a team as a code owner November 22, 2024 17:37

chloeYue marked this pull request as draft November 22, 2024 17:37

chloeYue changed the title ~~test: migrate test~~ test: [POM] Migrate create btc account e2e tests to TS and Page Object Model Nov 25, 2024

chloeYue changed the title ~~test: [POM] Migrate create btc account e2e tests to TS and Page Object Model~~ test: [POM] Migrate add token e2e tests to TS and Page Object Model Nov 25, 2024

Merge branch 'develop' into home-asset-page

6d122bc

Merge branch 'develop' into home-asset-page

07de661

chloeYue marked this pull request as ready for review November 26, 2024 09:00

seaona previously approved these changes Nov 26, 2024

View reviewed changes

Merge branch 'develop' into home-asset-page

577f106

chloeYue dismissed seaona’s stale review via 577f106 November 27, 2024 08:30

chloeYue requested a review from seaona November 27, 2024 09:06

DDDDDanica approved these changes Nov 27, 2024

View reviewed changes

seaona approved these changes Nov 27, 2024

View reviewed changes

chloeYue added this pull request to the merge queue Nov 27, 2024

Merged via the queue into develop with commit b6c750d Nov 27, 2024
75 checks passed

chloeYue deleted the home-asset-page branch November 27, 2024 12:29

github-actions bot locked and limited conversation to collaborators Nov 27, 2024

metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: [POM] Migrate add token e2e tests to TS and Page Object Model #28658

test: [POM] Migrate add token e2e tests to TS and Page Object Model #28658

chloeYue commented Nov 22, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Nov 22, 2024

Uh oh!

metamaskbot commented Nov 22, 2024

Uh oh!

metamaskbot commented Nov 25, 2024

Uh oh!

metamaskbot commented Nov 26, 2024

Uh oh!

seaona left a comment

Uh oh!

metamaskbot commented Nov 27, 2024

Uh oh!

Uh oh!

Uh oh!

test: [POM] Migrate add token e2e tests to TS and Page Object Model #28658

test: [POM] Migrate add token e2e tests to TS and Page Object Model #28658

Conversation

chloeYue commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Nov 22, 2024

Uh oh!

metamaskbot commented Nov 22, 2024

Uh oh!

metamaskbot commented Nov 25, 2024

Uh oh!

metamaskbot commented Nov 26, 2024

Uh oh!

seaona left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Nov 27, 2024

Uh oh!

Uh oh!

Uh oh!

chloeYue commented Nov 22, 2024 •

edited

Loading