chore: Restrict MMI test runs #28655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
added
team-extension-platform
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Builds ready [e493c5c]
Page Load Metrics (1966 ± 71 ms)
Bundle size diffs
|
The standard MMI e2e test suite now only runs on long-running branches, and for MMI-related changes. This should reduce CircleCI credit usage substantially.
Gudahtt
force-pushed
the
restrict-mmi-e2e-test-runs
branch
from
e493c5c to
3a363b5
Compare
Collaborator
Builds ready [3a363b5]
Page Load Metrics (2227 ± 104 ms)
Bundle size diffs
|
It was insufficient to use the trigger just to stop the build, because this trigger still leaves the job status as successful rather than skipped (so subsequent jobs still run).
Collaborator
Builds ready [6c07a66]
Page Load Metrics (1893 ± 112 ms)
Bundle size diffs
|
HowardBraham
approved these changes
Nov 22, 2024
danjm
approved these changes
Nov 25, 2024
desi
approved these changes
Nov 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-12.9.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The standard MMI e2e test suite now only runs on long-running branches, and for MMI-related changes. This should reduce CircleCI credit usage substantially.
Related issues
No issue. This is just to reduce credit usage.
Manual testing steps
We should see in the logs for the
test-e2e-mmijob on this PR that the tests were skipped.Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist