Skip to content

test: testing Confirmations e2e changes in all builds #28650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
seaona wants to merge 20 commits into from
Closed

test: testing Confirmations e2e changes in all builds #28650

seaona wants to merge 20 commits into from

Conversation

@seaona
Copy link
Member

@seaona seaona commented Nov 22, 2024 •
edited by github-actions bot
Loading

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Nov 22, 2024
@pedronfigueiredo pedronfigueiredo force-pushed the test-pnf/3026 branch 2 times, most recently from eeeb51d to 2827d40 Compare November 22, 2024 17:00
@pedronfigueiredo pedronfigueiredo mentioned this pull request Nov 25, 2024
Merged
7 tasks
@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 25, 2024

Builds ready [2827d40]
Page Load Metrics (1823 ± 148 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint154430231829306147
domContentLoaded151029951789306147
load154230271823308148
domInteractive147635168
backgroundConnect1080382311
firstReactRender53133982211
getState45316147
initialActions00000
loadScripts110221051305217104
setupStore65212136
uiStartup170432452017315151
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 993 Bytes (0.02%)
  • ui: 69 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 26, 2024

Builds ready [eef6015]
Page Load Metrics (2243 ± 236 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint39831721909776372
domContentLoaded156231012210490235
load157831522243492236
domInteractive28177654321
backgroundConnect15102402612
firstReactRender18102472613
getState765232010
initialActions01000
loadScripts113923841665412198
setupStore75922189
uiStartup177237452573617296
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 993 Bytes (0.02%)
  • ui: 69 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Base automatically changed from pnf/3026 to develop November 26, 2024 16:25
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kumavis kumavis Awaiting requested review from kumavis kumavis will be requested when the pull request is marked ready for review kumavis is a code owner

Assignees

No one assigned

Labels

team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@seaona @metamaskbot @pedronfigueiredo