Description

After the rerun from failed PR was merged there was one remaining filter to tweak, related to the scheduled trigger that will be done in the UI:

• In the Circle ci UI panel, there is no way to tell to trigger a specific workflow, rather all the config file will be checked, which means both the test_and_release and the rerun_from_failed workflows would run. For that, we need to add a filter in the test_and_release flow, so that is not run when we schedule the automatic runs using the name rerun-from-failed. Unfortunately there is no way to do this from the UI, so we need this filter in the config file

• I saw, that the rerun-failed workflow was run once the PR was merged, which shouldn't be the case. I've tweaked that following this example in circle ci docs)

Why this was missed: on the testing for the previous PR, I removed ALL the filters, to make the rerun-from-failed workflow run and check that it works (it worked). However, I didn't test leaving the filter of the [rerun-from-failed, << pipeline.schedule.name >>] and checking that it is not run

Related issues

Fixes:

Manual testing steps

How to test this: instead of removing ALL the filters (like it was done for testing the previous PR), just remove the filter for develop. This way, we can see if the job rerun-from-failed is run --> it shouldn't be, as it's not a scheduled run with that name.

It can be checked here: see only the test and release is run

For testing the scheduled run, it needs to be done in the UI once this PR is merged, but if the filter has been proven to work here, it should then also work there, for when it needs to be run

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.