feat: upgrade transaction controller to get incoming transactions using accounts API #28597

matthewwalsh0 · 2024-11-21T08:52:47Z

Description

Update @metamask/transaction-controller to retrieve incoming transactions using the accounts API rather than Etherscan.

Add incoming transaction E2E tests.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Remove multichain flag. Remove getCurrentChainId usage in background.

Fix unit tests. Update Lavamoat policies.

Use preview build.

Add queryEntireHistory and updateTransaction options. Revert state rename. Add E2E tests.

test/e2e/tests/transaction/incoming-transactions.spec.ts

socket-security · 2024-11-22T09:15:05Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	network	`0`	2.18 MB	metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

metamaskbot · 2024-11-22T14:00:55Z

Builds ready [a0c9c3f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1815 ± 70 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1571	2169	1825	144	69
		domContentLoaded	1561	2148	1774	141	67
		load	1570	2171	1815	145	70
		domInteractive	22	159	45	30	14
		backgroundConnect	11	159	39	37	18
		firstReactRender	74	383	135	78	37
		getState	5	88	26	26	13
		initialActions	0	1	0	0	0
		loadScripts	1113	1559	1295	110	53
		setupStore	6	86	12	17	8
		uiStartup	1757	2583	2080	249	120

Bundle size diffs [🚀 Bundle size reduced!]

background: 222 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: -5.82 KiB (-0.07%)

…obal-network

…into feat/incoming-transactions-accounts-api

metamaskbot · 2024-11-26T22:52:10Z

Builds ready [1e40b35]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1827 ± 155 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	213	2742	1659	515	247
		domContentLoaded	1479	2700	1782	325	156
		load	1491	2736	1827	323	155
		domInteractive	24	128	48	29	14
		backgroundConnect	8	130	45	33	16
		firstReactRender	16	72	36	22	10
		getState	4	59	14	13	6
		initialActions	0	1	0	0	0
		loadScripts	1041	2011	1294	266	128
		setupStore	6	50	13	12	6
		uiStartup	1652	3110	2007	354	170

Bundle size diffs [🚀 Bundle size reduced!]

background: 151 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: -4.87 KiB (-0.06%)

OGPoyraz

LGTM, will approve again after removing previews

socket-security · 2024-12-07T08:48:47Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

metamaskbot · 2024-12-07T09:42:25Z

Builds ready [08b6e5b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1799 ± 80 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	268	2070	1561	514	247
		domContentLoaded	1548	2304	1782	163	78
		load	1556	2308	1799	166	80
		domInteractive	23	72	31	12	6
		backgroundConnect	7	54	21	15	7
		firstReactRender	14	90	20	16	8
		getState	93	307	141	66	32
		initialActions	0	1	0	0	0
		loadScripts	1186	1861	1399	153	74
		setupStore	6	69	10	13	6
		uiStartup	1770	2647	2104	259	124

Bundle size diffs [🚀 Bundle size reduced!]

background: 429 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: -5.56 KiB (-0.07%)

matthewwalsh0 added 8 commits November 13, 2024 21:32

Use preview build

f77045d

Remove multichain flag. Remove getCurrentChainId usage in background.

Fix linting

5ca3702

Fix unit tests. Update Lavamoat policies.

Fix nonce lock call

cafd321

Remove debug logs

defa2e5

Restart incoming transaction polling on network change

0b5ce7b

Update Lavamoat policies

8c6efbf

Update MMI getTransactions usage

fcd95a7

Add E2E tests

156ee94

Use preview build.

matthewwalsh0 added the team-confirmations Push issues to confirmations team label Nov 21, 2024

matthewwalsh0 added 3 commits November 21, 2024 10:38

Fix E2E tests and linting

6389e71

Update version

3831d75

Add queryEntireHistory and updateTransaction options. Revert state rename. Add E2E tests.

Merge branch 'develop' into feat/incoming-transactions-accounts-api

293c7bf

github-advanced-security bot found potential problems Nov 22, 2024

View reviewed changes

test/e2e/tests/transaction/incoming-transactions.spec.ts Fixed Show fixed Hide fixed

matthewwalsh0 added 2 commits November 22, 2024 09:23

Fix E2E test

10eeeed

Remove regex

a0c9c3f

matthewwalsh0 added 7 commits November 26, 2024 09:20

Merge branch 'develop' into refactor/transaction-controller-remove-gl…

815aaed

…obal-network

Update preview build

c378718

Update version

856ae22

Merge branch 'develop' into refactor/transaction-controller-remove-gl…

bb8c668

…obal-network

Fix linting

7f8ea7d

Merge branch 'refactor/transaction-controller-remove-global-network' …

8bc76c8

…into feat/incoming-transactions-accounts-api

Fix E2E tests

cd63c28

matthewwalsh0 changed the base branch from develop to refactor/transaction-controller-remove-global-network November 26, 2024 21:59

Fix E2E test

1e40b35

matthewwalsh0 marked this pull request as ready for review November 27, 2024 08:32

matthewwalsh0 requested a review from a team as a code owner November 27, 2024 08:32

matthewwalsh0 mentioned this pull request Nov 27, 2024

feat: detect incoming transactions using accounts API MetaMask/core#4927

Merged

4 tasks

Base automatically changed from refactor/transaction-controller-remove-global-network to develop November 29, 2024 16:48

ziad-saab requested a review from a team as a code owner November 29, 2024 16:48

OGPoyraz previously approved these changes Dec 4, 2024

View reviewed changes

Merge branch 'main' into feat/incoming-transactions-accounts-api

5654392

matthewwalsh0 dismissed OGPoyraz’s stale review via 5654392 December 7, 2024 08:45

matthewwalsh0 added 2 commits December 7, 2024 08:49

Use real version

8fd4035

Fix linting

08b6e5b

matthewwalsh0 requested a review from OGPoyraz December 9, 2024 10:10

OGPoyraz approved these changes Dec 10, 2024

View reviewed changes

pedronfigueiredo approved these changes Dec 10, 2024

View reviewed changes

matthewwalsh0 added this pull request to the merge queue Dec 10, 2024

Merged via the queue into main with commit 8c8851a Dec 10, 2024
75 checks passed

matthewwalsh0 deleted the feat/incoming-transactions-accounts-api branch December 10, 2024 10:34

github-actions bot locked and limited conversation to collaborators Dec 10, 2024

metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: upgrade transaction controller to get incoming transactions using accounts API #28597

feat: upgrade transaction controller to get incoming transactions using accounts API #28597

Uh oh!

matthewwalsh0 commented Nov 21, 2024 •

edited

Loading

Uh oh!

Uh oh!

socket-security bot commented Nov 22, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Nov 22, 2024

Uh oh!

metamaskbot commented Nov 26, 2024

Uh oh!

OGPoyraz left a comment

Uh oh!

socket-security bot commented Dec 7, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Dec 7, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat: upgrade transaction controller to get incoming transactions using accounts API #28597

feat: upgrade transaction controller to get incoming transactions using accounts API #28597

Uh oh!

Conversation

matthewwalsh0 commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

Uh oh!

socket-security bot commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Nov 22, 2024

Uh oh!

metamaskbot commented Nov 26, 2024

Uh oh!

OGPoyraz left a comment

Choose a reason for hiding this comment

Uh oh!

socket-security bot commented Dec 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Dec 7, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

matthewwalsh0 commented Nov 21, 2024 •

edited

Loading

socket-security bot commented Nov 22, 2024 •

edited

Loading

socket-security bot commented Dec 7, 2024 •

edited

Loading