Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code style issues #3667

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Conversation

JLdgu
Copy link
Contributor

@JLdgu JLdgu commented Sep 8, 2024

F to M Converters.
Use pattern matching where appropriate.

@Keboo Keboo enabled auto-merge (squash) September 10, 2024 14:28
JLdgu and others added 25 commits November 8, 2024 08:17
…rialDesignInXAML#3681)

* Extend SmartHint demo page to reproduce multi-line issue

Signed-off-by: Nicolai Henriksen <[email protected]>

* Expose TextBox.LineCount as an attached property
TextBox.LineCount is not a DP on the TextBox control. So we add a behavior that can be attached which will listen for text changes and update the AP accordingly. This allows us to bind to TextFieldAssist.LineCount where needed.

Signed-off-by: Nicolai Henriksen <[email protected]>

* Add AutoSuggestBox to SmartHint demo page

Signed-off-by: Nicolai Henriksen <[email protected]>

* Modify initial vert offset converter to use lineCount in calculations

Signed-off-by: Nicolai Henriksen <[email protected]>

* Apply LineCount AP in relevant styles

Signed-off-by: Nicolai Henriksen <[email protected]>

* Change default RichTextBox.VerticalContentAlignment for best fit with floating hint

Signed-off-by: Nicolai Henriksen <[email protected]>

* Align AcceptsReturn=True and TextWrapping=Wrap behaviors

* Remove left-over debug code

---------

Signed-off-by: Nicolai Henriksen <[email protected]>
…terialDesignInXAML#3682)

Bumps [fastify/github-action-merge-dependabot](https://github.com/fastify/github-action-merge-dependabot) from 3.10.1 to 3.10.2.
- [Release notes](https://github.com/fastify/github-action-merge-dependabot/releases)
- [Commits](fastify/github-action-merge-dependabot@v3.10.1...v3.10.2)

---
updated-dependencies:
- dependency-name: fastify/github-action-merge-dependabot
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rialDesignInXAML#3689)

* Ensure behavior triggers AP change on initial binding

* Make helper APs public

* Apply renamed APs
…ine and multi-line selection (MaterialDesignInXAML#3690)

* Add SmartHint.HintHost

* Use SmartHint.HintHost to trigger hint position recalculation

* Set SmartHint.HintHost in ComboBox style

* Set SmartHint.HintHost in TextBox and AutoSuggestBox styles
Returning to the ElementName binding avoids the exception, but introduces a temporary binding error. Adding the converter effectively avoids the binding error.
…ML#3680)

* fixed typo in tool tip in MenusAndToolBars

* Make ListBoxItem in Demo actually toggleable that should be toggleable

---------

Co-authored-by: Corvin Szimion <[email protected]>
…gnInXAML#3701)

* Add AP to use for padding brush

* Apply AP in SmartHint style

* Forward AP and remove no longer needed trigger in TextBox style

* Apply AP fix in AutoSuggestBox style

* Apply AP fix in PasswordBox style

* Apply AP fix in ComboBox style

* Apply AP fix in DatePicker style

* Apply AP fix in TimePicker style

* Add showcasing of AP to demo apps

* Adjust UI tests

* Update src/MaterialDesignThemes.Wpf/HintAssist.cs

Co-authored-by: Kevin B <[email protected]>

---------

Co-authored-by: Kevin B <[email protected]>
* add card to demo app showcasing this bug

* removed Background of nested Border in the AdornerLayer

* added Margin and CornerRadius to the inner Border of the AdornerDecorator in the Card, to circumvent white edges showing up around the Card
* Cleanup of launchSettings and Cards Page in Demo

* Revert "Cleanup of launchSettings and Cards Page in Demo"

This reverts commit ede38d4.

* Cleanup of launchSettings and Cards Page in Demo

---------

Co-authored-by: Corvin Szimion <[email protected]>
…terialDesignInXAML#3704)

Bumps [fastify/github-action-merge-dependabot](https://github.com/fastify/github-action-merge-dependabot) from 3.10.2 to 3.11.0.
- [Release notes](https://github.com/fastify/github-action-merge-dependabot/releases)
- [Commits](fastify/github-action-merge-dependabot@v3.10.2...v3.11.0)

---
updated-dependencies:
- dependency-name: fastify/github-action-merge-dependabot
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

* Use shared ButtonsViewModel

* Fix link to view model
…3709)

Added another file for Optimizing-WPF-Rendering-Performance
…signInXAML#3711)

* Add supporting AP for the HintPaddingBrush

* Reintroduce style triggers to set supporting AP
…L#3715)

* Create Optimizing-WPF-Rendering-Performance.md

Added another file for Optimizing-WPF-Rendering-Performance

* Create Freezable_Object_for_Enhanced_Performance.md
* Create Optimizing-WPF-Rendering-Performance.md

Added another file for Optimizing-WPF-Rendering-Performance

* Create Reducing_Layout_Complexity.md

* Rename Reducing_Layout_Complexity to Reducing_Layout_Complexity.md
* Create Optimizing-WPF-Rendering-Performance.md

Added another file for Optimizing-WPF-Rendering-Performance

* Create Optimize_UI_Thread_Performance.md

* Update Optimize_UI_Thread_Performance.md

* Update Optimize_UI_Thread_Performance.md
…increase or decrease can be set. (MaterialDesignInXAML#3661)

* Support decimals value, and the size of value for each increase or decrease can be set.

* UpDown control support decimals, and the value for each increase or decrease can be set.

* Updates to UpDownBase to support generic math on NET8

TODO: Need to fix XAMLTest to support the common generic base class so the generator stops choking

* Updating UI tests

Updated new XAMLTest library
Added DeciamlUpDown tests

---------

Co-authored-by: Kevin Bost <[email protected]>
Co-authored-by: Kevin Bost <[email protected]>
* Cleanup of launchSettings and Cards Page in Demo

* Revert "Cleanup of launchSettings and Cards Page in Demo"

This reverts commit ede38d4.

* fixed a bug in the demo app which removed the wrong TabItem in the TabControl of which the TabItems can be "closed"

* Clean up binding path

---------

Co-authored-by: Corvin Szimion <[email protected]>
Co-authored-by: Kevin Bost <[email protected]>
auto-merge was automatically disabled November 8, 2024 08:23

Head branch was pushed to by a user without write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants