Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes to please the linter. #73

Merged
merged 3 commits into from
Sep 9, 2017
Merged

Small fixes to please the linter. #73

merged 3 commits into from
Sep 9, 2017

Conversation

RobinJadoul
Copy link
Collaborator

The version in the manifest is also invalid currently, because of the "rc" suffix.

LEDfan
LEDfan approved these changes Sep 9, 2017
View reviewed changes
Copy link
Owner

@LEDfan LEDfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original fix would break the select multiple password field:
moz-extension --7a261c5b-0195-4536-880e-69db89a6608f - selecteer paswoord - nightly_708

I have adapted the code to use the JS create/adept elements API, which actually simplifies the code 😃

@LEDfan
Copy link
Owner

LEDfan commented Sep 9, 2017

The version in the manifest is also invalid currently, because of the "rc" suffix.

It's firefox specific, but for now we only support FF so it's okay I guess.

@RobinJadoul do you think this should go into 1.0.0?

@Riajyuu
Copy link
Contributor

Riajyuu commented Sep 9, 2017 •
edited
Loading

Though it is out of my concern, I suggest Yes.

@RobinJadoul
Copy link
Collaborator Author

@LEDfan Unless you want to wait for #74 that's okay for me

@LEDfan LEDfan added this to the 1.0.0 milestone Sep 9, 2017
@LEDfan LEDfan closed this Sep 9, 2017
@LEDfan LEDfan reopened this Sep 9, 2017
@LEDfan LEDfan merged commit d258f75 into master Sep 9, 2017
@LEDfan LEDfan deleted the lint_fix branch September 9, 2017 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LEDfan LEDfan LEDfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@RobinJadoul @LEDfan @Riajyuu