Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set version to 2.0.0-DEV #536

Merged
merged 1 commit into from
Jun 7, 2023
Merged

set version to 2.0.0-DEV #536

merged 1 commit into from
Jun 7, 2023

Conversation

palday
Copy link
Member

@palday palday commented Jun 7, 2023

There are changes currently on master that we have determined are Technically Breaking. Setting the version to 2.0.0-DEV indicates the next version that will be released from master and that we're not yet in the state we want for that release.

There are changes currently on `master` that we have determined are Technically Breaking. Setting the version to 2.0.0-DEV indicates the next version that will be released from master and that we're not yet in the state we want for that release.
@palday palday requested review from kleinschmidt and nalimilan June 7, 2023 16:02
Copy link
Member

@kleinschmidt kleinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that communicating this is important somehow (I've made a mistake before because I didn't understand that master was meant to be 2.0). I'm not 100% sure this is the way to do it but it does have the advantage that when someone goes to bump the version in PR, they will notice that it's 2.0.0-DEV, so I don't see a better/safer way.

@palday palday merged commit c13577e into master Jun 7, 2023
@palday palday deleted the pa/2.0.0-dev branch June 7, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants