-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libjulia for latest master #5934
Conversation
I would strongly prefer the jll version to match the actual Julia version... otherwise things get confusing. |
But what is the "actual julia version" given that this ships 1.6 - 1.10 in various variants :-) |
Oh right... Morning brain |
Perhaps it should be the maximum of all versions, so here still 1.10 ? Whatever we agree on (or agreeD ON -- I probably just forgot the outcome) I suggest we add it as a comment to avoid repeating the discussion needlessly:-) |
Hrm, 1.9 fails in mingw, and 1.10 fails everywhere:
|
ef59130
to
6184447
Compare
OK, I went one commit back, leaving out Julia commit JuliaLang/julia@41b73e2 ("Bump libuv"). That resolves the 1.10 builds for now. That leaves the failing mingw builds. |
Once again it is that msys patch that is not applied since the julia version changed from 1.9.0-DEV to 1.9.0-alpha1 which doesn't match the folder name anymore. Instead of the patch we might also try to remove the fake uname at the beginning of the build:
(This reports that it is running in an MSY2 shell instead of a Linux build-os) But I can't test this right now since for some reason I am hitting that
locally, even with the current Yggdrasil master instead of the updates from this branch. |
6184447
to
2e43c78
Compare
Julia PR #44527 changes how foreign types work. To accommodate this, we need a new libjulia_jll.
2e43c78
to
4465b9c
Compare
Urgh, one would think I'd have learned that by now :-(. Thank you, trying that now. Assuming this works, I'd like to merge and then try the "remove fake uname" trick in a separate PR (it would be nice to not require those patches) |
Julia PR #44527 changes how foreign types work. To accommodate this, we need a new libjulia_jll
I think this PR is meant to be backported to the release-1.9 branch. At that point, another update of libjulia_jll will be needed. But I am not sure when this backport will happen, and so I'd like to just move ahead with this now, so that I can un-break our CI tests against Julia nightly.
BTW, I've updated the version for libjulia_jll here. In the past we didn't always do that. I am not really sure if I am "supposed" to increment the version, or supposed to not do that and just add a whitespace to force a rebuild... I don't mind either way... shrug