-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group import hints #56753
base: master
Are you sure you want to change the base?
Group import hints #56753
Conversation
Seems sensible overall, modulo comment. |
Does need a test though. |
There's also some trailing whitespace that needs to be removed. You can see where on the "files changd" tab of this PR. (Some editors have an option to strip trailing whitespace automatically) |
In thinking about how to test this, I've come across what may be a problem. If I do module A
export f
f() = 0.0
end
module B
import ..A: f
export f
end
module C
import ..B: f
public f
end
module D
public f
f() = 1.0
end
append!(Base.loaded_modules_order, [A, B, C, D]) # is there a less gross way?
import .B Then the hints for
The problem here is that (unlike The same thing happens with 1.11. hints on 1.11
I think the problem arises from calling I would welcome input here about whether or not this is out of scope for this PR, and whether there is a better way to test this. |
I haven't looked closely enough to determine whether |
This is my attempt to resolve #53000.
I would have beefed up the test case, but can't follow how it works.