Add option to spawn timer tasks to avoid stickiness #56745
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this a new option? Isn't spawning strictly better? |
|
In case there are use cases where code relies on the behavior. Maybe not needed? |
Sadly needed. |
vchuravy
reviewed
Dec 6, 2024
vchuravy
reviewed
Dec 6, 2024
Co-authored-by: Valentin Churavy <[email protected]>
IanButterworth
changed the title
why is it needed? |
|
We should also look for uses of Timer and change them. I also think that this should change the default. Having spooky action at a distance be why someones code is working is not correct. The fact that we sticky is not documented anywhere. |
|
What about spawn if the parent task isn't sticky already? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Timer(f, 1)will create a sticky task and have the same effect as@asyncin making the parent task also sticky.I'm not sure if this should be treated as a bugfix (i.e. backport) or a minor behavior change (i.e. introduce in 1.12).
Or just an opt-in new feature, so
spawn=falseby default.Now off by default.