Fix --project=@script when outside script directory
#56351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awadell1
force-pushed
the
at-script-fix
branch
from
3828fad to
ab89939
Compare
|
As best I can tell, the test failure appears unrelated to this PR. Should be good for review |
Tests for JuliaLang#55606 and JuliaLang#55069
As detailed in JuliaLang#55069, PROGRAM_FILE and ARGS are unset when `load_path_expand` is first called during `Base.__init__()`, this adds `program_file` to JLOptions as sets it during `jl_parse_opts` Removed `unsafe_load_commands` path in `load_path_expand` as ARGS is unset at this point.
awadell1
force-pushed
the
at-script-fix
branch
from
e16c447 to
c142f78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #55069 and #55606
As discussed in #55069, this PR adds a
program_filefield toJLOptions, allowing the program file to be defined duringBase.__init__()whenload_path_expandis first called. The PR is broken into four commits:--project=@scripthelp text to the cli