Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for MMTk (non-moving immix) #56288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding support for MMTk (non-moving immix) #56288

wants to merge 1 commit into from

Conversation

udesou
Copy link
Contributor

@udesou udesou commented Oct 22, 2024

This PR adds the possibility of building/running Julia using MMTk, running non-moving immix.
The binding code (Rust) associated with it is in https://github.com/mmtk/mmtk-julia/tree/upstream-ready/immix. Instructions on how to build/run Julia with MMTk are described in the README file inside the binding repo.

@udesou udesou changed the title Adding non-moving immix Adding support for MMTk (non-moving immix) Oct 22, 2024
gbaraldi
gbaraldi reviewed Oct 22, 2024
View reviewed changes
src/gc-mmtk.c Outdated Show resolved Hide resolved
@nsajko nsajko added the GC Garbage collector label Oct 22, 2024
Keno
Keno reviewed Oct 22, 2024
View reviewed changes
src/llvm-late-gc-lowering.cpp Outdated Show resolved Hide resolved
Keno
Keno reviewed Oct 23, 2024
View reviewed changes
src/llvm-late-gc-lowering.cpp Outdated Show resolved Hide resolved
@udesou udesou force-pushed the upstream-ready/immix branch 4 times, most recently from 5257d4a to 4621e5c Compare October 25, 2024 03:42
@udesou udesou marked this pull request as ready for review October 25, 2024 03:46
d-netto
d-netto reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@d-netto d-netto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review pass.

Will follow-up with more comments soon.

src/Makefile Outdated Show resolved Hide resolved
src/builtins.c Outdated Show resolved Hide resolved
src/gc-mmtk.h Outdated Show resolved Hide resolved
src/gc-mmtk.h Outdated Show resolved Hide resolved
src/gc-tls.h Outdated Show resolved Hide resolved
src/llvm-gc-interface-passes.h Outdated Show resolved Hide resolved
@udesou udesou force-pushed the upstream-ready/immix branch 4 times, most recently from 3e68f3c to 6a01c26 Compare December 2, 2024 04:53
@udesou udesou force-pushed the upstream-ready/immix branch from 6a01c26 to bc08a9b Compare December 3, 2024 09:13
d-netto
d-netto reviewed Dec 4, 2024
View reviewed changes
src/gc-interface.h Outdated Show resolved Hide resolved
src/gc-interface.h Show resolved Hide resolved
src/gc-stock.c Show resolved Hide resolved
src/gc-stock.c Show resolved Hide resolved
src/gc-stock.c Outdated Show resolved Hide resolved
src/threading.c Outdated Show resolved Hide resolved
Keno
Keno reviewed Dec 4, 2024
View reviewed changes
src/gc-mmtk.c Outdated Show resolved Hide resolved
Keno
Keno reviewed Dec 4, 2024
View reviewed changes
stdlib/REPL/src/REPL.jl Outdated Show resolved Hide resolved
d-netto
d-netto reviewed Dec 4, 2024
View reviewed changes
src/gc-common.c Show resolved Hide resolved
src/gc-common.h Outdated Show resolved Hide resolved
src/gc-stock.c Outdated Show resolved Hide resolved
src/gc-mmtk.c Outdated Show resolved Hide resolved
src/gc-stock.c Show resolved Hide resolved
@udesou udesou force-pushed the upstream-ready/immix branch 7 times, most recently from 167c10f to c6fd2d9 Compare December 10, 2024 02:21
gbaraldi
gbaraldi reviewed Dec 11, 2024
View reviewed changes
src/gc-mmtk.c Outdated Show resolved Hide resolved
d-netto
d-netto reviewed Dec 11, 2024
View reviewed changes
base/timing.jl Outdated Show resolved Hide resolved
contrib/refresh_checksums.mk Outdated Show resolved Hide resolved
src/gc-common.h Outdated Show resolved Hide resolved
src/gc-mmtk.c Outdated Show resolved Hide resolved
src/gc-mmtk.c Outdated Show resolved Hide resolved
@udesou udesou force-pushed the upstream-ready/immix branch 4 times, most recently from 5a5bdac to 926e78b Compare December 12, 2024 01:47
@udesou udesou force-pushed the upstream-ready/immix branch from 926e78b to 8ddb110 Compare December 12, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-netto d-netto d-netto left review comments

@gbaraldi gbaraldi gbaraldi left review comments

@qinsoon qinsoon qinsoon left review comments

@Keno Keno Keno left review comments

Assignees
No one assigned
Labels
GC Garbage collector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@udesou @Keno @qinsoon @gbaraldi @d-netto @nsajko