Make threadpoolsize(), threadpooltids(), and ngcthreads() public #55701
Conversation
|
(bump) |
oscardssmith
added
needs decision
|
|
|
But I need to care about it 😅 For context, this is the usecase that motivated the PR: https://github.com/Gnimuc/CImGui.jl/blob/7c315112271b61d59c35873a2f1691021fb40198/ext/GlfwOpenGLBackend.jl#L177 That function allows pinning a task on a specific thread or in a given threadpool, which is sometimes necessary for libuv/GLFW reasons, but to do that I do need a valid thread ID. I could try recomputing the valid thread IDs but that's not completely trivial going from the definition so I feel that it would better if this was public. |
|
Making something public is a commitment to an API, which we are not ready to make. It's often fine to access internals, but you need to be aware of the fact that you are doing so (and you don't get to complain when a future Julia version changes things on you). So |
These are already mentioned in the docs.
JamesWrigley
force-pushed
the
threading-functions
branch
from
7ed0d87 to
5ecd21c
Compare
|
Ok, fair enough 👍 I rebased the branch and removed |
threadpoolsize()andngcthreads()were already in the docs anyway, andthreadpooltids()is useful for checking which threads belong to a pool.