Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate BuildKite test UUIDs on a per-test basis #53556

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Generate BuildKite test UUIDs on a per-test basis #53556

wants to merge 1 commit into from

Conversation

tecosaur
Copy link
Contributor

@tecosaur tecosaur commented Mar 2, 2024

UUIDs should be generated per-test not per-testset.

See commit message for more info.

@tecosaur
Generate BuildKite test UUIDs on a per-test basis
9ee75b8 
According to <https://buildkite.com/docs/test-analytics/importing-json>,
UUIDs should be per-test. In the initial implementation, UUIDs were
assigned on a per-testset basis, which is not quite correct.

This is fixed by moving the UUID generation from the testset "common"
information section, to the per-test information generation.
@tecosaur tecosaur added testsystem The unit testing framework and Test stdlib ci Continuous integration labels Mar 2, 2024
@tecosaur
Copy link
Contributor Author

tecosaur commented Mar 3, 2024 •
edited
Loading

There's interest in changing the approach to just on testset-level granularity, however I haven't been able to work out how to get this to work with passing test sets.

In the meantime, this improves what we currently have going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci Continuous integration testsystem The unit testing framework and Test stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tecosaur