Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strengthen setglobal to default to release-consume ordering #47742

Merged
merged 1 commit into from
Nov 30, 2022
Merged

strengthen setglobal to default to release-consume ordering #47742

merged 1 commit into from
Nov 30, 2022

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Nov 29, 2022

In looking at a TSAN report recently, I noticed that globals were getting stored as atomic-unordered (since c92ab5e #44182), instead of atomic-release as intended (since 46135df #45484).

@vtjnash
strengthen setglobal to default to release-consume ordering
c5cce00 
In looking at a TSAN report recently, I noticed that globals were
getting stored as atomic-unordered (since c92ab5e #44182), instead
of atomic-release as intended (since
46135df #45484).
@vtjnash vtjnash added multithreading Base.Threads and related functionality backport 1.9 Change should be backported to release-1.9 labels Nov 29, 2022
@vtjnash vtjnash merged commit f4534d1 into master Nov 30, 2022
@vtjnash vtjnash deleted the jn/release-refs-globals branch November 30, 2022 19:19
KristofferC pushed a commit that referenced this pull request Dec 8, 2022
@vtjnash @KristofferC
strengthen setglobal to default to release-consume ordering (#47742)
628c953 
In looking at a TSAN report recently, I noticed that globals were
getting stored as atomic-unordered (since c92ab5e #44182), instead
of atomic-release as intended (since
46135df #45484).

(cherry picked from commit f4534d1)
This was referenced Dec 8, 2022
Merged
Merged
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
multithreading Base.Threads and related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtjnash @KristofferC