Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Markdown header underlines #47708

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Fix Markdown header underlines #47708

merged 2 commits into from
Nov 28, 2022

Conversation

adrhill
Copy link
Contributor

@adrhill adrhill commented Nov 25, 2022

Closes #47632.

Before After
before after

I'm not sure how to run stdlib tests locally, but it would probably be a good idea to add one.

@KristofferC
Copy link
Member

Thanks for the PR. Looks like the test in

julia/stdlib/Markdown/test/runtests.jl

Line 379 in 04214ec

" Title\n ≡≡≡≡≡≡≡\n\n Some discussion\n\n │ A quote\n\n Section important\n ===================\n\n Some bolded\n\n • list1\n\n • list2"
needs to be updated.

@brenhinkeller brenhinkeller added the needs tests Unit tests are required for this change label Nov 25, 2022
@KristofferC KristofferC removed the needs tests Unit tests are required for this change label Nov 27, 2022
@fredrikekre fredrikekre merged commit 99be295 into JuliaLang:master Nov 28, 2022
@adrhill adrhill deleted the ah/fix-md-header-length branch November 28, 2022 09:47
@adrhill adrhill mentioned this pull request Nov 28, 2022
Merged
@bkamins bkamins mentioned this pull request Nov 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
markdown
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markdown header underlines are overly long
4 participants
@adrhill @KristofferC @brenhinkeller @fredrikekre