Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for Julia 1.8.4 #47488

Merged
merged 26 commits into from
Dec 16, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
1b5c405
move src and dst to next buffer position (#47229)
awfeequdng Nov 2, 2022
9d86e4f
CircleCI caching: allow ftime to be ceil(ftime_req) in Base.stale_cac…
nrontsis Nov 4, 2022
90ee1b5
Delete `.github/workflows/rerun_failed.yml` (#47460)
DilumAluthge Nov 6, 2022
b66e38c
Removed attributes from arguments to gc_preserve_begin (#47482)
apaz-cli Nov 8, 2022
1387750
Delete `.github/workflows/statuses.yml` (#47562)
DilumAluthge Nov 17, 2022
c8b72e2
[CompilerSupportLibraries_jll] Upgrade to libraries from GCC 12 (#47544)
tylerjthomas9 Nov 22, 2022
96592e2
Probe and dlopen() the correct libstdc++ (#46976)
apaz-cli Nov 8, 2022
b183031
Limit initial OpenBLAS thread count (#46844)
staticfloat Nov 15, 2022
b19b2c1
Turn on Intel jitevents by default on Linux (#47586)
vchuravy Nov 20, 2022
54a6264
Filesystem: `rm(; recursive=true)` should ignore `UV_EACCES` (#47668)
staticfloat Nov 24, 2022
6dad6c5
Fix REPL keybinding CTRL-Q for stdlib methods (#47637)
rashidrafeek Nov 28, 2022
70c8dc2
fix 5-arg `mul!` for vectors of vectors (#47665)
ranocha Nov 28, 2022
8abef03
fix #47662, broken --compile=all on 1.8.x (#47678)
JeffBezanson Dec 2, 2022
23ce8ab
Fix implicit binding import for aliased bindings (#44827)
Pangoraw Apr 2, 2022
4898882
Add compat to `@test_throws` (#45893)
baggepinnen Jul 5, 2022
2950963
Fix generator-invocation legality check for varargs generators (#47739)
Keno Nov 29, 2022
c1d3df6
Prioritize build_dir for generated headers (#47783)
vchuravy Dec 4, 2022
579f84f
Fix physical_memory exports. (#47859)
maleadt Dec 10, 2022
964f86d
fix #47410, syntax error with anonfn inside `elseif` and short-circui…
JeffBezanson Nov 16, 2022
f5c000e
ensure bindings handle write barriers for ty and globalref (#47580)
vtjnash Nov 16, 2022
4e152d4
fix unescaping in `global` expressions (#47719)
simeonschaub Dec 1, 2022
8830c26
Set `OPENBLAS_NUM_THREADS=1` on local Distributed workers (#47803)
staticfloat Dec 5, 2022
fd92d74
Fix isdone for empty product iterators, fixes #43921 (#43947)
sasi591 Nov 3, 2022
5a1d35e
Merge pull request #47741 from JuliaLang/jn/backports-release-1.8-47685
KristofferC Dec 14, 2022
992d4ca
bump SparseArrays to latest 1.8
Dec 14, 2022
3f58584
bump Pkg to latest 1.8
Dec 15, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Set OPENBLAS_NUM_THREADS=1 on local Distributed workers (#47803)
This should prevent LinearAlgebra from trying to increase our OpenBLAS
thread count in its `__init__()` method when we're not trying to enable
threaded BLAS.

(cherry picked from commit a8b3994)
  • Loading branch information
staticfloat authored and KristofferC committed Dec 14, 2022
commit 8830c265eb1813bbf98b5fd7bb39a44b88892b7f
1 change: 1 addition & 0 deletions stdlib/Distributed/src/cluster.jl
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,7 @@ default_addprocs_params() = Dict{Symbol,Any}(
:dir => pwd(),
:exename => joinpath(Sys.BINDIR, julia_exename()),
:exeflags => ``,
:env => [],
:enable_threaded_blas => false,
:lazy => true)

Expand Down
10 changes: 9 additions & 1 deletion stdlib/Distributed/src/managers.jl
Original file line number Diff line number Diff line change
Expand Up @@ -462,10 +462,18 @@ function launch(manager::LocalManager, params::Dict, launched::Array, c::Conditi
exename = params[:exename]
exeflags = params[:exeflags]
bind_to = manager.restrict ? `127.0.0.1` : `$(LPROC.bind_addr)`
env = Dict{String,String}(params[:env])

# If we haven't explicitly asked for threaded BLAS, prevent OpenBLAS from starting
# up with multiple threads, thereby sucking up a bunch of wasted memory on Windows.
if !params[:enable_threaded_blas] &&
get(env, "OPENBLAS_NUM_THREADS", nothing) === nothing
env["OPENBLAS_NUM_THREADS"] = "1"
end

for i in 1:manager.np
cmd = `$(julia_cmd(exename)) $exeflags --bind-to $bind_to --worker`
io = open(detach(setenv(cmd, dir=dir)), "r+")
io = open(detach(setenv(addenv(cmd, env), dir=dir)), "r+")
write_cookie(io)

wconfig = WorkerConfig()
Expand Down