Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treat CartesianIndex as a broadcast scalar #47044

Merged
merged 3 commits into from
Jan 28, 2023
Merged

treat CartesianIndex as a broadcast scalar #47044

merged 3 commits into from
Jan 28, 2023

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Oct 4, 2022 •
edited by mbauman
Loading

Fixes #38432 and #41540.

@stevengj stevengj added the broadcast Applying a function over a collection label Oct 4, 2022
@stevengj stevengj requested a review from mbauman October 4, 2022 12:15
@stevengj
Copy link
Member Author

CI Error in testset Downloads seems to be unrelated.

@stevengj
Copy link
Member Author

Ping @mbauman.

@stevengj stevengj force-pushed the sgj/cartesianindex_scalar branch from 674351e to 0a6e294 Compare November 19, 2022 15:10
@stevengj
Copy link
Member Author

stevengj commented Nov 19, 2022 •
edited
Loading

Rebased. Marking as "triage" since this is a very simple PR and it would be good to get a decision.

@stevengj stevengj added the triage This should be discussed on a triage call label Nov 19, 2022
@jishnub jishnub mentioned this pull request Jan 25, 2023
Open
@mbauman
Copy link
Member

mbauman commented Jan 26, 2023

I don't think we need triage here — this is pretty unobjectionable. Let's just do this!

@mbauman mbauman removed the triage This should be discussed on a triage call label Jan 26, 2023
@stevengj stevengj force-pushed the sgj/cartesianindex_scalar branch from 4775407 to 414026f Compare January 27, 2023 19:06
@stevengj
Copy link
Member Author

rebased

@stevengj stevengj added the merge me PR is reviewed. Merge when all tests are passing label Jan 27, 2023
@DilumAluthge DilumAluthge merged commit 8b9da8d into master Jan 28, 2023
@DilumAluthge DilumAluthge deleted the sgj/cartesianindex_scalar branch January 28, 2023 09:22
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbauman mbauman mbauman approved these changes

Assignees
No one assigned
Labels
broadcast Applying a function over a collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make CartesianIndexs broadcast like scalars?
3 participants
@stevengj @mbauman @DilumAluthge