Handle Vararg in PartialStruct fields in lattice ⊑ #46515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an existing todo. While we're at it, also explicitly check the remaining cases where lattice elements survived all the way to the conservative fallback and remove it in preparation for some refactoring here.
vtjnash
reviewed
Aug 31, 2022
| return a <: b | ||
| else # handle this conservatively in the remaining cases | ||
| elseif isa(a, PartialTypeVar) | ||
| return b === TypeVar || a === b |
There was a problem hiding this comment.
Is it legal to compare these with ===? That is not a lattice-preserving operation for the TypeVar object inside.
There was a problem hiding this comment.
That is unchanged in this PR, the condition just moved around. I agree that it might not be sound though.
There was a problem hiding this comment.
Ah, gotcha. It was hard to see that in the default unified diff; easier in the split diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an existing todo. While we're at it, also explicitly
check the remaining cases where lattice elements survived
all the way to the conservative fallback and remove it in
preparation for some refactoring here.