Add property in searchsortedfirst docstring #46511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
reviewed
Aug 29, 2022
base/sort.jl
Outdated
| @@ -333,6 +333,8 @@ Return the index of the first value in `a` greater than or equal to `x`, accordi | |||
| specified order. Return `lastindex(a) + 1` if `x` is greater than all values in `a`. | |||
| `a` is assumed to be sorted. | |||
|
|
|||
| This is the last index at which `x` could be `insert!`ed to maintian sorted order. | |||
There was a problem hiding this comment.
Suggested change
| This is the last index at which `x` could be `insert!`ed to maintian sorted order. | |
| This is the last index at which `x` could be `insert!`ed to maintain sorted order. |
There was a problem hiding this comment.
This is the last index at which
xcould beinsert!ed to maintian sorted order.
What am I missing here?
julia> x = [1,2,4,5,5,7];
julia> idx = searchsortedfirst(x, 4)
3
julia> insert!(x, idx+1, 4) # not idx
7-element Vector{Int64}:
1
2
4
4
5
5
7
julia> issorted(x)
true
There was a problem hiding this comment.
It is I that was missing something.
Co-authored-by: Daniel Karrasch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a pretty common use case and worth addressing specifically in the docstring.