fix Base.return_types for direct builtin calls
#46443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
force-pushed
the
avi/return_types_builtin
branch
from
4842df0 to
ff85ff8
Compare
vtjnash
reviewed
Sep 1, 2022
| end | ||
| effects = Core.Compiler.EFFECTS_TOTAL | ||
| matches = _methods(f, types, -1, world)::Vector | ||
| if isempty(matches) |
There was a problem hiding this comment.
shouldn't this need to check for the ambiguous flag and fully_covers flag (like inlining) to be entirely correct? (if so, we can convert this comment to a new issue)
There was a problem hiding this comment.
Yes, we should account for that. This isempty-based check is not sound.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also changed this fragile test case
to
since
Expris just a generic function and can be overloadedin the future (e.g. the JuliaSyntax.jl integration PR).