Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the Core.Compiler.@show helper. #46423

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Improve the Core.Compiler.@show helper. #46423

merged 1 commit into from
Aug 29, 2022

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Aug 20, 2022 •
edited
Loading

Add support for multiple arguments, returning the last value, just like how Base.@show works.

@maleadt
Improve the Core.Compiler.@show helper.
2186281 
Add support for multiple arguments, returning the last value,
just like how Base.@show works.
@maleadt maleadt requested a review from ianatol August 20, 2022 07:05
ianatol
ianatol approved these changes Aug 20, 2022
View reviewed changes
Copy link
Member

@ianatol ianatol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ianatol ianatol added the merge me PR is reviewed. Merge when all tests are passing label Aug 22, 2022
@KristofferC KristofferC merged commit ccf04c2 into master Aug 29, 2022
@KristofferC KristofferC deleted the tb/core_compiler_show branch August 29, 2022 19:22
@oscardssmith oscardssmith removed the merge me PR is reviewed. Merge when all tests are passing label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianatol ianatol ianatol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maleadt @ianatol @KristofferC @oscardssmith