Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "build: cleanup base files inclusion" #46420

Merged
merged 1 commit into from
Aug 20, 2022
Merged

Revert "build: cleanup base files inclusion" #46420

merged 1 commit into from
Aug 20, 2022

Conversation

Keno
Copy link
Member

@Keno Keno commented Aug 19, 2022

This change broke Revise. @JeffBezanson and I discussed this with a number of folks and the consensus was that:

  1. We don't think the src/base thing really makes much sense.
  2. We don't like not having symlinks, because that makes everything show up twice in grep and IDEs
  3. Having Revise working is significantly more important than the original bug this fixed, which seems like it should be fixable by other Makefile improvements without touching the directory structure.

Reverts #45441.

@DilumAluthge DilumAluthge requested a review from vtjnash August 19, 2022 21:07
@Keno
Copy link
Member Author

Keno commented Aug 20, 2022

Both Jeff and Jameson are on vacation now, but Jeff told me to do this in person, so I'll just consider than a review approval ;).

@Keno Keno merged commit a77ba79 into master Aug 20, 2022
@Keno Keno deleted the revert-45441-jn/make_base_files branch August 20, 2022 01:42
@DilumAluthge DilumAluthge added the revert This reverts a previously merged PR. label Aug 21, 2022
@timholy timholy mentioned this pull request Aug 25, 2022
Closed
@vtjnash vtjnash mentioned this pull request Nov 19, 2022
Merged
@vtjnash vtjnash mentioned this pull request Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

@staticfloat staticfloat Awaiting requested review from staticfloat

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
revert This reverts a previously merged PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Keno @DilumAluthge