[ASAN] Turn off asan instrumentation in segv handler #46377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's some issues around asan and segv handlers. The issues I'm aware of is: 1. If things run on the sigaltstack, we need to at some point unpoison the sigaltstack and it's not clear when to do that. 2. Sanitizers accidentally free stil-in-use stack frames: google/sanitizers#1561 3. If noreturn functions run on the sigaltstack, asan can get confused about what it needs to unpoison So for now, remove asan instrumentation from the segv_handler and the the jl_call_in_ctx functions (jl_sig_throw is already annotated). This helps the case I was seeing (where gc_srub would cause frequent segv_handler invocations for safe restore), but there's probably a few other landmines remaining here.
60 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some issues around asan and segv handlers. The issues
I'm aware of is:
the sigaltstack and it's not clear when to do that.
asan fake stack can free live stack frames after longjmp/signal google/sanitizers#1561
about what it needs to unpoison
So for now, remove asan instrumentation from the segv_handler and
the the jl_call_in_ctx functions (jl_sig_throw is already annotated).
This helps the case I was seeing (where gc_srub would cause frequent
segv_handler invocations for safe restore), but there's probably a few
other landmines remaining here.