Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly declare alloca alignment #46368

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Properly declare alloca alignment #46368

merged 1 commit into from
Aug 16, 2022

Conversation

Keno
Copy link
Member

@Keno Keno commented Aug 16, 2022

Turns out when you declare an alloca alignment, it also rounds up
the allocated size. Replaces #46322 and #46260 and fixes the
same issue.

@Keno
Properly declare alloca alignment
4e9b46d 
Turns out when you declare an alloca alignment, it also rounds up
the allocated size. Replaces #46322 and #46260 and fixes the
same issue.
@Keno Keno mentioned this pull request Aug 16, 2022
Open
60 tasks
@gbaraldi
Copy link
Member

Not sure if nullptr is better than NULL here, but other than that LGTM.

@Keno Keno merged commit e358a17 into master Aug 16, 2022
@Keno Keno deleted the kf/allocaalign branch August 16, 2022 21:29
@maleadt
Copy link
Member

maleadt commented Aug 17, 2022

Backport?

@KristofferC KristofferC added the backport 1.8 Change should be backported to release-1.8 label Aug 17, 2022
@KristofferC KristofferC mentioned this pull request Aug 17, 2022
Merged
35 tasks
@maleadt
Copy link
Member

maleadt commented Aug 17, 2022

I think this could also be backported to 1.6, in case we want another LTS release.

@maleadt maleadt added the backport 1.6 Change should be backported to release-1.6 label Aug 17, 2022
KristofferC pushed a commit that referenced this pull request Aug 26, 2022
@Keno @KristofferC
Properly declare alloca alignment (#46368)
649f568 
Turns out when you declare an alloca alignment, it also rounds up
the allocated size. Replaces #46322 and #46260 and fixes the
same issue.

(cherry picked from commit e358a17)
KristofferC pushed a commit that referenced this pull request Aug 26, 2022
@Keno @KristofferC
Properly declare alloca alignment (#46368)
29c76db 
Turns out when you declare an alloca alignment, it also rounds up
the allocated size. Replaces #46322 and #46260 and fixes the
same issue.

(cherry picked from commit e358a17)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Sep 7, 2022
@KristofferC KristofferC mentioned this pull request Dec 21, 2022
Closed
78 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport 1.6 Change should be backported to release-1.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Keno @gbaraldi @maleadt @KristofferC