-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove DelimitedFiles from being an stdlib #45540
Conversation
fc83af7
to
e4b3114
Compare
@KristofferC I think you mentioned somewhere that there were some issues with Compat. Perhaps good to capture those here. |
Yes, So as it is right now, there are a bunch of packages that depend on standard libraries. The compatibility requirements for stdlib dependencies are implicit in the julia compatibility. Now, a stdlib gets moved out to become a standard package (let's call this an ex-stdlib). It will be versioned like a normal package and people with put compat on it like a normal package. There are a few questions that arises now:
I think I have to play around with this a bit locally and create "fake packages" that set up these scenarios to conclusively say what is best to do here. |
If I may ask, what's the reasoning / motivation for dropping DelimitedFiles as a stdlib? I might have missed it but haven't seen a discussion about this anywhere. |
This is being planned not just DelimitedFiles, but also Statistics and the sparse ecosystem. In my opinion, there are several benefits:
Various things are being planned to make this non-breaking, and more are discovered as we go forward:
|
2 is very valid, and 4 would be awesome! 3 is interesting, in that on one hand that's almost certainly true, but on the other hand it can be nice to have Base and Stdlibs as an "api" of sorts that other packages can extend (i.e., you should import and extend I still have a knee-jerk reaction ("surely this will end up breaking someone's workflow anyways" "ok, so they'll still get checked in pkgeval, but what if something breaks them anyways, there won't be as much pressure to fix downstream", etc.), but that's probably paranoid. All in all it's probably (?) worth it as long as it really really isn't breaking and everyone's |
I don't think that these need to live in Base or as stdlib. They are much better suited for a StatsBase.jl or StatsCore.jl or StatsAPI.jl package that is developed freely by the statistics community in Julia without language release cycles and related concerns. |
We want to get rid of SuiteSparse test dependency on DelimitedFiles. Regarding the compat problem, I think things should be ok if we retroactively add compat to an ex-stdlib, duplicating that of the Julia version, and setting the version of the ex-stdlib to that of the Julia version when it moves out. So DelimitedFiles would get version 1.9.0 in this case. Here is a commit that adds the compat to DelimitedFiles as an example: JuliaRegistries/General@969344d. Made with https://github.com/KristofferC/StdlibRegistryCompatUpdater |
SuiteSparse test dependency on DelimitedFiles is fixed in #45972 |
Wondering if we can get this in before the 1.9 feature freeze. |
e4b3114
to
68356a8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@nanosoldier |
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
No new errors about uninstallable packages, so that looks good? |
Yep! |
I want to run the Pkg tests using the JuliaRegistries/General#66039 branch of the registry. If that passes, I think we are good to go. |
f3c9577
to
c60c8e2
Compare
c60c8e2
to
f6ae634
Compare
Requires JuliaLang/Pkg.jl#3097 and JuliaRegistries/General#61457
Fixes #44663