make ml_matches return nothing when there are too many matches
#44478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liozou
reviewed
Mar 6, 2022
aviatesk
force-pushed
the
avi/overlayedfindsup
branch
from
219f08d to
c86d43a
Compare
aviatesk
force-pushed
the
avi/toomanynothing
branch
2 times, most recently
from
20d11d4 to
c85b7c3
Compare
aviatesk
commented
Mar 7, 2022
aviatesk
force-pushed
the
avi/toomanynothing
branch
from
bf4862d to
35c07f1
Compare
vtjnash
reviewed
Mar 8, 2022
There was a problem hiding this comment.
Seems right, but @JeffBezanson should also review, probably, since he originally made this return false.
aviatesk
force-pushed
the
avi/toomanynothing
branch
2 times, most recently
from
e8bf652 to
0cbcdbd
Compare
aviatesk
force-pushed
the
avi/toomanynothing
branch
2 times, most recently
from
9e14841 to
c445ac0
Compare
|
Is there any plan for this? I would like to know before bumping #44434 because of a minor conflict in REPLCompletions.jl. |
aviatesk
force-pushed
the
avi/toomanynothing
branch
from
c445ac0 to
b61fbce
Compare
|
bump? this should be good to merge |
aviatesk
force-pushed
the
avi/toomanynothing
branch
3 times, most recently
from
04f6c8f to
9aa1f00
Compare
Continuation from <#44448 (comment)>. Previously `ml_matches` (and its dependent utilities like `_methods_by_ftype`) returned `false` for cases when there are too many matching method, but its consumer like `findall(::Type, ::InternalMethodTable)` usually handles such case as `missing`. This commit does a refactor so that they all use the more consistent value `nothing` for representing that case.
aviatesk
force-pushed
the
avi/toomanynothing
branch
from
9aa1f00 to
5a227f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation from #44448 (comment).
Previously
ml_matches(and its dependent utilities like_methods_by_ftype)returned
falsefor cases when there are too many matching method, butits consumer like
findall(::Type, ::InternalMethodTable)usually handlessuch case as
missing. This commit does a refactor so that they all usethe more consistent value
nothingfor representing that case.