[master] README: update the Buildkite badges now that we have separate pipelines for the master branch
#41604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
added
backport 1.6
DilumAluthge
force-pushed
the
dpa/readme-buildkite-badges
branch
from
86924a0 to
33d1c02
Compare
staticfloat
reviewed
Jul 15, 2021
README.md
Outdated
Comment on lines
15
to
18
| [![Build status (LTS)][buildkite-lts-img]][buildkite-lts-url] | ||
| [![Build status (stable)][buildkite-stable-img]][buildkite-stable-url] | ||
| [![Build status (master)][buildkite-master-img]][buildkite-master-url] | ||
| [![Build status (scheduled)][buildkite-scheduled-master-img]][buildkite-scheduled-master-url] |
There was a problem hiding this comment.
I wonder if, instead, we should just have a single build status, but on master branch it points to buildkite-master-url, and on 1.6, it points to its own.
There was a problem hiding this comment.
I was thinking it's nice to be able to go to the README and see all of the statuses quickly, instead of needing to go to each branch individually.
There was a problem hiding this comment.
I don't think one branch should be advertising the build status of other branches; it makes it look like master is broken, when really some other branch is the one that is broken.
DilumAluthge
removed
backport 1.6
DilumAluthge
changed the title
DilumAluthge
changed the title
DilumAluthge
changed the title
master branch
…e pipelines for the `master` branch
DilumAluthge
force-pushed
the
dpa/readme-buildkite-badges
branch
from
b1b6e7d to
61ea17a
Compare
|
Alright, I've made PRs so that each branch only advertises its own build status. |
DilumAluthge
requested review from
staticfloat
and removed request for
staticfloat
|
@staticfloat Is this good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.