README: Move the CI badges to the bottom of the README #41374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I moved the coverage badges and the Buildkite badges to the bottom of the README. I kept the docs badge at the top. We could also keep the coverage badges at the top of the README, and only move the Buildkite badges to the bottom. I think it makes sense to keep the docs badge at the top? |
|
Why? Pretty much every single project I have seen has these somewhere at the top where an overall CI status + coverage status is shown. I also don't really get the merge process here. 50 minutes ago @fredrikekre was asked to review it, then there was a follow-up comment with some question and then the PR just got merged within the hour of getting opened? What's the hurry? |
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.