Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol change from git to https in README.md #40675

Merged
merged 1 commit into from
May 4, 2021
Merged

Protocol change from git to https in README.md #40675

merged 1 commit into from
May 4, 2021

Conversation

xgupta
Copy link
Contributor

@xgupta xgupta commented May 1, 2021

https is a common protocol for cloning git repositories, we should use that one.

latter for pushing a change to the origin when we run git push --set-upstream origin master an error message comes stating :
fatal: remote error:
You can't push to git://github.com/JuliaLang/julia.git
Use https://github.com/JuliaLang/julia.git

@giordano
Copy link
Contributor

giordano commented May 1, 2021

latter for pushing a change to the origin when we run git push --set-upstream origin master an error message comes stating :
fatal: remote error:
You can't push to git://github.com/JuliaLang/julia.git
Use https://github.com/JuliaLang/julia.git

Isn't the problem that you don't have commit access to this repository, whatever protocol you use?

@xgupta
Copy link
Contributor Author

xgupta commented May 1, 2021

Okay, I don't understand, but if you are saying and have two like on your comment, I accept it.

@xgupta xgupta closed this May 1, 2021
@StefanKarpinski
Copy link
Member

The point he's making is that you don't have permission to push to the julia repo over any protocol, so changing the protocol doesn't help: most people — yourself included — will not be able to push to the repo. The only people who can are people who have commit bit and by the time someone has that, they've probably sorted out what protocols they need to use to be able to push things to GitHub.

The git protocol is very basic and should work for everyone, which is probably why I picked it — even if your local CA root certs are messed up it will work. However, it's not encrypted, so there is a slight risk that people could get man-in-the-middled. Of course, no git hashes will be correct if any content has been modified, but people might not check those. So the argument for switching to https would that it's more secure, which is probably a good reason to do it.

@StefanKarpinski StefanKarpinski added the merge me PR is reviewed. Merge when all tests are passing label May 3, 2021
@simeonschaub simeonschaub merged commit ab04170 into JuliaLang:master May 4, 2021
jarlebring pushed a commit to jarlebring/julia that referenced this pull request May 4, 2021
jarlebring pushed a commit to jarlebring/julia that referenced this pull request May 6, 2021
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@simeonschaub simeonschaub removed the merge me PR is reviewed. Merge when all tests are passing label May 21, 2021
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants