Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macos codesign workflow #39152

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Fix macos codesign workflow #39152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix macos codesign workflow 
We changed the permissions on executable files which caused this `find`
to not find any of the actual binaries that we need to sign.  Change it
to instead find anything with any executable permissions set, rather
than ones with exactly the permissions `0755`
  • Loading branch information
@staticfloat
staticfloat committed Jan 8, 2021
commit 635428a6df7e10a9e2f5f10686eba98390eb7685
2 changes: 1 addition & 1 deletion contrib/mac/app/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ dmg/$(APP_NAME): startup.applescript julia.icns
find $@/Contents/Resources/julia -type f -exec chmod -w {} \;
if [ -n "$$MACOS_CODESIGN_IDENTITY" ]; then \
echo "Codesigning with identity $$MACOS_CODESIGN_IDENTITY"; \
MACHO_FILES=$$(find "$@" -type f -perm -755 | cut -d: -f1); \
MACHO_FILES=$$(find "$@" -type f -perm -0111 | cut -d: -f1); \
for f in $${MACHO_FILES}; do \
echo "Codesigning $${f}..."; \
codesign -s "$$MACOS_CODESIGN_IDENTITY" --option=runtime --entitlements Entitlements.plist -vvv --timestamp --deep --force "$${f}"; \
Expand Down