Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logo in readme from within the repository #37627

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Use logo in readme from within the repository #37627

merged 1 commit into from
Sep 17, 2020

Conversation

oxinabox
Copy link
Contributor

We were loading the logo from the www.julialang.org website.
Apparently that logo moved or something tas the link is now broken.

We have a copy of the logo inside the repo already.
For sake of being self-contained and making this less likely to occur in future
maybe it is better to just refer to that?

@simeonschaub
Copy link
Member

Is it safe to assume that all browsers can render SVGs?

@oxinabox
Copy link
Contributor Author

Is it safe to assume that all browsers can render SVGs?

In short: yes.

Internet Explorer 8 was the last browser that supported images that couldn't.
It was the default browser that came with Windows 7.
But i think it gets replaced as soon as you run windows update.
Internet explorer 9 was released in March 2011, and fully supports SVGs.

@simeonschaub
Copy link
Member

But IE8 is my favorite browser! 😆

@ViralBShah
Copy link
Member

I think we should load the logos from https://github.com/JuliaLang/julia-logo-graphics

Those are the official source of logos. Pulling from there means you always get the latest one, and those URLs and filenames will be the most stable since they rarely change.

@fredrikekre
Copy link
Member

The one in this repo needs to be updated for the docs anyway, so might as well reuse it in the readme.

@fredrikekre fredrikekre merged commit 840e2fc into JuliaLang:master Sep 17, 2020
@giordano giordano mentioned this pull request Sep 20, 2020
Closed
@giordano
Copy link
Contributor

giordano commented Sep 20, 2020 •
edited
Loading

I don't see the logo rendered on my phone (chrome on android). edit: nevermind, I think it was a cache issue

@oxinabox oxinabox deleted the patch-39 branch September 21, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oxinabox @simeonschaub @ViralBShah @fredrikekre @giordano